Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40812

Lessons: Student Pages disappear when students start to edit their pages

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.4, 12.5, 19.0, 20.0 [Tentative]
    • Fix Version/s: 12.6, 19.0, 20.0 [Tentative]
    • Component/s: Lessons
    • Labels:
      None
    • 19 status:
      Resolved
    • 12 status:
      Please Merge
    • Test Plan:
      Hide

      Please add a Test Plan here.

      Show
      Please add a Test Plan here.

      Description

      We had professors reporting that the "Student Pages" got disappeared at some point after students started creating their pages and adding/editing their student page contents.

      All of the reports of this case relate to "Student Content" item configured with comments and peer review checked.

      1. Add a comments section to each page
      2. Add a peer review rubric to each page

      We investigated and found there were a pattern happened, which result in several updates in the lesson_builder_items update before inserting a content item in the student page.

      Among those updates, there are two updates that I couldn't understand and all the other updates seems making sense as they move the sequence of existing items in the student page.

      Those two weird updates and caused the issue of "Student Pages" disappearing for instructor are:

      1. It updates the 'Comments Section' item of that student page, set the sequence to "1";

            something like:

            UPDATE lesson_builder_items

            SET sequence=1

            WHERE pageid=-1, sequence=0, type=9,sakaiId=5158, title=

      'Comments Section'

       

                This results that particular student ends up seeing the "Comment" section listing on top of the page with the editing icon available for him.  (normally editor icon is not showing for comment item inside student page and should show up at bottom of the page)

       

           2. another update is changing "Student Content" item to "PEEREVAL" type;

              something like this:

              UPDATE lesson_builder_items

              SET pageId=-10, sequence=1,type=13,sakaiId=5158,title='peerEval' ......

              WHERE id=5385605, pageid=987842, ...., type=10,title='Student Content Section'

      ..........

             This results that "Student Pages" disappeared for Instructor and also student won't see their pages either since that "Student Pages" item was updated to "PEEREVAL" item in that page.

      I looked at code in SimplePageBean.java,  method  getItemsOnPage  line 1800 (sakai 11.4)

      where for eval, each student page get adding an eval item on the fly,

                              studItem.setType(SimplePageItem.PEEREVAL); // peer eval defined in SimplePageItem.java
                              studItem.setId(item.getId());
                              items.add(0,studItem);

       

      I didn't dive deeper into lessons code before, and don't understand

      1. why need to setId to be the same as "Student Conent" item id; could it be random id?

      studItem.setId(item.getId());

      2. how one of this got executed into table lessons_builder_items?

      Not sure why all these happened.

       

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  yq12 Yuanhua Qu
                  Reporter:
                  yq12 Yuanhua Qu
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code