Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40831

chef_assignments_list_assignments.vm missing closing comment tag

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 12.5, 19.0
    • Fix Version/s: 19.2, 20.0
    • Component/s: Assignments
    • Labels:
      None
    • 19 status:
      Verified
    • 12 status:
      Please Merge
    • Test Plan:
      Hide
      1. login as an instructor and open the assignment tool
      2. create an assignment (that ends a few minutes in the future) that uses Peer Assessments and requires students to review other students assignments
      3. login as a student and open the assignment tool
      4. complete the assignment
      5. go back to the main assignment page
      6. wait for the assignment to 'end' (optional?)
      7. refresh the page and right click the page -> view page source
      8. search for
        <!-- peer assessment is open and user has submitted, show item details -->
        
      1. ensure that that line has a closing comment tag
      2. ensure that that line is followed by
        <tr>
        <!-- attachments col -->
        <td></td>
        
      1. and that the <tr> tag does NOT appear commented out
      2. search for and ensure the following lines appears and contains closing comment brackets
        <!-- peer assessment items rows -->
        
        <!-- End peer assessment items rows -->
        
      Show
      login as an instructor and open the assignment tool create an assignment (that ends a few minutes in the future) that uses Peer Assessments and requires students to review other students assignments login as a student and open the assignment tool complete the assignment go back to the main assignment page wait for the assignment to 'end' (optional?) refresh the page and right click the page -> view page source search for <!-- peer assessment is open and user has submitted, show item details --> ensure that that line has a closing comment tag ensure that that line is followed by <tr> <!-- attachments col --> <td></td> and that the <tr> tag does NOT appear commented out search for and ensure the following lines appears and contains closing comment brackets <!-- peer assessment items rows --> <!-- End peer assessment items rows -->

      Description

      chef_assignments_list_assignments.vm is missing/bad a closing comment tag

      <!-- peer assessment is open and user has submitted, show item details

      <!-- End peer assessment items rows->

      #if ($!submission && $!service.isPeerAssessmentOpen($!assignment) && $!reviews)
      	<!-- peer assessment is open and user has submitted, show item details
      	#set ($reviewCount = 0)
      	#foreach ($review in $reviews)
      		#set ($reviewCount = $reviewCount + 1)
      		<tr>
      			<!-- attachments col -->
      .
      .
      .
      		#end
      	#end
      <!-- End peer assessment items rows->
      
      <!-- End Peer assessment rows -->
      #end
      

      I don't think it's causing any issues, perhaps modern browser's are able to figure out what you mean? but it'd be best to fix it anyway

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                austinUH Austin
                Reporter:
                austinUH Austin
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration