Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40855

Assignments instructor's student view peer review row's columns are shifted to the wrong column

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 12.5, 19.0, 20.0
    • Fix Version/s: 12.6, 19.0, 20.0
    • Component/s: Assignments
    • Labels:
      None
    • 19 status:
      Resolved
    • 12 status:
      Resolved
    • Test Plan:
      Hide
      • Create an assignment with peer review
      • click the "student view" tab
      • ensure that the peer review row's column data is in the correct column
      • Test this with sites that do NOT have groups
      • Test this with site that HAVE groups
      • Login as a student
      • submit the test
      • Login as another student
      • submit the test
      • let the assignment close (to generate peer reviews)
      • Test the 'actual' student view looks ok too...
        • the peer review row as shown in the screenshot below
        • 'other student's peer review rows'
      Show
      Create an assignment with peer review click the "student view" tab ensure that the peer review row's column data is in the correct column Test this with sites that do NOT have groups Test this with site that HAVE groups Login as a student submit the test Login as another student submit the test let the assignment close (to generate peer reviews) Test the 'actual' student view looks ok too... the peer review row as shown in the screenshot below 'other student's peer review rows'

      Description

      • Create an assignment with peer review
      • click the "student view" tab
      • the peer review row's column data is shifted one column to the left

      The problem does not happen if the site has groups/sections... however, I maybe that that's just a side effect because the code generates an extra <td> if there are groups.

      chef_assignments_list_assignments.vm (Sakai 12, lines 514, 617)

      <!-- Peer assessment rows -->
      #if($assignment.getAllowPeerAssessment() && !($allowAddAssignment && $!view.equals('lisofass1')))
      	#set($reviews = $peerAssessmentItemsMap.get($assignment.Id))
      	<!-- only show to "students" -->
      	<!-- peer assessment overview row -->
      	<tr>
      		<!-- attachments col -->
      		<td></td>
      		<!-- title col -->
      		<td class="peer-header">
      			<strong title="$validator.escapeHtml($!assignment.Title)"><span class="fa fa-caret-square-o-right" aria-hidden="true"></span> $validator.escapeHtml($assignment.Title)</strong>
      			<em>$tlang.getString("peerAssessmentName")</em>
      		</td>
      		#if ($!groups && $!allowGradeSubmission)
      			<!-- groups col -->
      			<td></td>
      		#end
      		<!-- status col -->
      		<td>
      .
      .
      .
      <!-- peer assessment items rows -->
      #if ($!submission && $!service.isPeerAssessmentOpen($!assignment) && $!reviews)
      	<!-- peer assessment is open and user has submitted, show item details -->
      	#set ($reviewCount = 0)
      	#foreach ($review in $reviews)
      		#set ($reviewCount = $reviewCount + 1)
      		<tr>
      			<!-- attachments col -->
      			<td></td>
      			<!-- title col -->
      			<td>
      				<span class="indnt2">
      					#if($review.getSubmitted())
      						$tlang.getFormattedMessage("peerassessment.student", $reviewCount)&nbsp;<img src="/library/image/silk/accept.png"/>
      					#else
      						<a name="asnActionLink" href="#toolLinkParam("$action" "doEdit_review" "assignmentId=$validator.escapeUrl($assignmentReference)&submissionId=$validator.escapeUrl($review.id.SubmissionId)")">
      							$tlang.getFormattedMessage("peerassessment.student", $reviewCount)
      						</a>
      					#end
      				</span>
      			</td>
      			#if ($!groups && $!allowGradeSubmission)
      				<!-- groups col -->
      				<td></td>
      			#end
      

        Gliffy Diagrams

          Zeplin

            Attachments

            1. 12312018_peer_review_groups.gif
              15 kB
              Andrea Schmidt
            2. 12312018_peer_review_no_groups.gif
              16 kB
              Andrea Schmidt
            3. peer-review-instructor-student-view.png
              102 kB
              Austin
            4. sak-40855_fixed.png
              163 kB
              Austin

              Activity

                People

                Assignee:
                bergarvi Bernardo Garcia Vila
                Reporter:
                austinUH Austin
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration