Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40883

Wiki > fix link macro for relative links

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 11.4, 12.4, 19.0, 20.0 [Tentative]
    • Fix Version/s: 19.0, 20.0 [Tentative]
    • Component/s: Rwiki
    • Labels:
      None
    • 19 status:
      Resolved
    • Test Plan:
      Hide

      In any site with the Wiki tool:

      1. Create a link macro with a relative URL, like the following:
        {link://dev.thlib.org}
        
      2. Save the page, then click the link
      3. Verify you're transferred to the URL
      Show
      In any site with the Wiki tool: Create a link macro with a relative URL, like the following: {link://dev.thlib.org} Save the page, then click the link Verify you're transferred to the URL

      Description

      In it's current form, the link macro aborts processing any relative URLs when clicked by the user:

      04-Nov-2018 11:27:25.370 WARN [https-jsse-nio-8452-exec-5] uk.ac.cam.caret.sakai.rwiki.component.macros.SakaiLinkMacro.execute RWiki URL (//dev.thlib.org) looks invalid so we're removing it from the display.
      

      The linked PR extends the link macro to allow relative URLs.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                bjones86 Brian Jones
                Reporter:
                bjones86 Brian Jones
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code