Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-40997

lessons: Add Content Links regression - cannot enter a title/link text for the item being linked.

    Details

    • Test Plan:
      Hide

      Testing if fixed:

      1. Add Lessons and Resources to your site.
      2. Upload a file to Resources.
      3. On the lesson page, select Add Content, then Add Content Links.
      4. Add a link to an external web page: make sure you can enter link text as well as the URL, and the link is created correctly.
      5. Select Add Content, then Add Content Links, and enter a URL without entering link text. The URL should be added to the page without issue (and the link text should be the URL itself).
      6. Select Add Content, then Add Content Links and choose Or select existing files from Resources.
      7. Select the file you uploaded and Continue.
      8. Make sure you can enter meaningful link text to accompany the file link, and when you create the link, the link text you entered displays instead of the file name.
      9. Select Add Content, then Add Content Links and choose Or select existing files from Resources.
      10. Select the file you uploaded and Continue.
      11. Make sure you can create the link without entering any link text (and it just displays the file name as the link text).
      Show
      Testing if fixed: Add Lessons and Resources to your site. Upload a file to Resources . On the lesson page, select Add Content , then Add Content Links . Add a link to an external web page: make sure you can enter link text as well as the URL , and the link is created correctly. Select Add Content , then Add Content Links , and enter a URL without entering link text. The URL should be added to the page without issue (and the link text should be the URL itself). Select Add Content , then Add Content Links and choose Or select existing files from Resources . Select the file you uploaded and Continue . Make sure you can enter meaningful link text to accompany the file link, and when you create the link, the link text you entered displays instead of the file name. Select  Add Content , then  Add Content Links  and choose  Or select existing files from Resources . Select the file you uploaded and  Continue . Make sure you can create the link without entering any link text (and it just displays the file name as the link text).

      Description

      While reviewing SAK-40973, I noticed that at some point in Sakai 12, the following issue was introduced in the Lessons Add Content Links feature: the Item Name option (in this case, the link text) was removed.

      This poses an accessibility issue because it prevents instructors from adding meaningful link text when creating links. Link text should be meaningful, per the following WCAG Success Criterion: Link purpose in context

      I can't find a jira mentioning the removal of the Item Name box; if it was done intentionally, I assume it was because the link silently failed to be created if the box was not filled. However, this should be fixed by allowing the link to be created with the URL or file name as link text, not by removing the box.

      Below are screen shots of where the option existed in Sakai 11, and how the feature now looks in Sakai 12-19:

      Proper behavior in https://qa11-mysql.nightly.sakaiproject.org/portal/

      Missing option in https://experimental.nightly.sakaiproject.org/portal/

      I recommend the following fixes:

      1. Restore the functionality of the Item Name box.
      2. Give the box a more meaningful label, for example Title or Link Text.
      3. Make it so that links can be created with or without the Item Name box being filled, in which case the URL would be the link text if it's pointing to an external web page, or the file name would be the link text if the link is pointing to a resource in the Sakai site.

      See Testing Steps for more information about desired behavior.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  maintenanceteam Core Team
                  Reporter:
                  rainribbon Tiffany Stull
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration