Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-41161

Calendar height on weekly view is displaying literal divHeight

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 19.0, 20.0
    • Fix Version/s: 20.0
    • Component/s: Calendar
    • Labels:
      None
    • 19 status:
      Resolved
    • Test Plan:
      Hide
      • Create a calendar entry that spans at least an hour
      • Go to the weekly view
      • Using the browsers inspector (In Chrome right click and hit inspect), on the default Elements tab select the div for the event that you created in the table.

      Expected: The "height" in the style should be a numeric value

      Actual: It displays $divHeight

      See screenshot (scroll to the right for the HTML inspector)

      Show
      Create a calendar entry that spans at least an hour Go to the weekly view Using the browsers inspector (In Chrome right click and hit inspect), on the default Elements tab select the div for the event that you created in the table. Expected: The "height" in the style should be a numeric value Actual: It displays $divHeight See screenshot (scroll to the right for the HTML inspector)

      Description

      There was a regression from SAK-21242 that's causing the literal "divHeight" to print in the style rather than the numeric value. This is because it has $numbreOfSections-1 in the vm setter which it thinks is a variable rather than a calculation. I'll submit a PR for this. 

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration