Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-41232

GradebookNG > improve ability to import a custom exported file

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 12.5, 19.0, 20.0 [Tentative]
    • Fix Version/s: 12.6, 19.0, 20.0 [Tentative]
    • Component/s: Gradebook
    • Labels:
      None
    • 19 status:
      Resolved
    • 12 status:
      Resolved
    • Test Plan:
      Hide
      1. In a site with Gradebook, add several gradebook items and give several students grades
      2. Do a custom export of the gradebook, enabling all checkboxes
      3. Verify the following in the exported file:
        1. The "Student ID" and "Student Name" column are the 1st and 2nd columns
        2. The "Student Display ID" is the 3rd column, and is prefixed with the "#" character
      4. Edit the file and make some grade and/or comment changes
      5. Select the file for importing and finish the upload process
      6. Verify the upload works as expected, and the grade and/or comment changes have been made appropriately
      Show
      In a site with Gradebook, add several gradebook items and give several students grades Do a custom export of the gradebook, enabling all checkboxes Verify the following in the exported file: The "Student ID" and "Student Name" column are the 1st and 2nd columns The "Student Display ID" is the 3rd column, and is prefixed with the "#" character Edit the file and make some grade and/or comment changes Select the file for importing and finish the upload process Verify the upload works as expected, and the grade and/or comment changes have been made appropriately

      Description

      When you elect to do a custom export of the Gradebook, the message to the user states:

      Customized exports can only be imported back into the system if Student ID and Student Name are retained in the first and second columns and all other formatting conventions are followed.

      However, the "Student Display ID" option is in between the "Student ID" and "Student Name" options (the two which must be retained as the first and second columns in the file in order to make it compatible with the import function). If "Student Display ID" is selected, it effectively produces a CSV which will not be able to be imported because the "Student Display ID" column will be in the second column. the "Student Display ID" column is also not prefixed with the "#" prefix, which tells the import function to ignore the column.

      If a user were to try to upload the file after making some grade changes, they would be presented with an error message, and they would likely be confused because the two columns necessary have technically been retained, but are not in the right places due to their selections for the custom export. In order to fix this on their own, the user would have to realize the column order doesn't match what the message originally said, they would have to manually reorder the columns, and add the "#" prefix to the "Student Display ID" column, save and re-upload.

      A better solution to this is to alter the code so that the "Student Display ID" column comes after the "Student Name" column, and is prefixed with the "#" so it isn't interpreted as a gradebook item.

        Gliffy Diagrams

          Attachments

          1. 1a-before.png
            1a-before.png
            110 kB
          2. 1b-before.png
            1b-before.png
            7 kB
          3. 2a-after.png
            2a-after.png
            114 kB
          4. 2b-after.png
            2b-after.png
            6 kB

            Issue Links

              Activity

                People

                • Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  bjones86 Brian Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code