Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-41235

GradebookNG > restore ability for Instructor to remove all TA permissions

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 19.0, 20.0 [Tentative]
    • Fix Version/s: 19.0, 20.0 [Tentative]
    • Component/s: Gradebook
    • Labels:
      None
    • 19 status:
      Resolved
    • Test Plan:
      Hide
      1. In a site with at least 2 users in the TA role, create at least two groups with different students in each.
      2. Confirm that by default, TAs can see and enter grades in all gradebook items and categories.
      3. Instructor can restrict TA as follows, with correct behavior on each restriction or combination of restrictions:
        • Remove all permissions by clicking Remove - TA sees the message "You do not have permission to view the gradebook. Please contact your instructor."
        • Set permission to View All - TA can view but not enter grades (lock icon).
        • Set permission to view or enter grades in some categories but not all (appropriate grades are shown and/or can be entered).
        • Set permission to view or enter grades for specific rosters/groups and confirm these work.
        • Set a combination of permissions (e.g. view grades for specific roster/group but grade different roster/group and categories) and confirm these work.
        • Restore default permissions for a TA by clicking Revert to Default.
      Show
      In a site with at least 2 users in the TA role, create at least two groups with different students in each. Confirm that by default, TAs can see and enter grades in all gradebook items and categories. Instructor can restrict TA as follows, with correct behavior on each restriction or combination of restrictions: Remove all permissions by clicking Remove - TA sees the message "You do not have permission to view the gradebook. Please contact your instructor." Set permission to View All - TA can view but not enter grades (lock icon). Set permission to view or enter grades in some categories but not all (appropriate grades are shown and/or can be entered). Set permission to view or enter grades for specific rosters/groups and confirm these work. Set a combination of permissions (e.g. view grades for specific roster/group but grade different roster/group and categories) and confirm these work. Restore default permissions for a TA by clicking Revert to Default .

      Description

      In GradebookNG for Sakai 11.x and 12.x, Instructors had the ability to remove all gradebook specific permissions for the Teaching Assistants in their site. If they removed all permissions in their gradebook, this would effectively override the realm permissions for the TA realm role. In GradebookNG for Sakai 19.x+ Instructors no longer have this ability; this is a regression in the eyes of users.

      If the user does not read the (slightly long) information message at the top of the screen, they will likely be quite confused when the click 'Remove' on what is actually the default level of access granted by the realm role permissions, then click 'Save', only to see the success message and the exact same permission they just tried to delete reappear.

      The linked PR reintroduces the behaviour from 12 and previous, where if the user removes the last remaining permission in the UI, this overrides the realm permissions such that the TA will not be able to see anything. It also introduces a 'Revert to Default' button on the bottom of the form, to revert the permissions back to the default, realm role provided permissions. The instruction message is also modified to remove mention of the (somewhat strange) mechanism of restoring defaults by removing the last remaining.

        Gliffy Diagrams

          Attachments

          1. 1a-before.png
            1a-before.png
            76 kB
          2. 2a-after.png
            2a-after.png
            74 kB
          3. 2b-after.png
            2b-after.png
            72 kB
          4. Screenshot_20190125_101100.png
            Screenshot_20190125_101100.png
            68 kB
          5. Screenshot_20190125_101233.png
            Screenshot_20190125_101233.png
            65 kB
          6. Screenshot_20190125_101358.png
            Screenshot_20190125_101358.png
            72 kB
          7. TA_Defaults.mp4
            3.20 MB

            Issue Links

              Activity

                People

                • Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  bjones86 Brian Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code