Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-41283

Create a new API that can persist grades without comments

    XMLWordPrintable

    Details

    • Type: Feature Request
    • Status: OPEN
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 19.0, 20.0 [Tentative]
    • Fix Version/s: None
    • Component/s: edu-services, Gradebook
    • Labels:
    • Test Plan:
      Hide

      Please add a Test Plan here.

      Show
      Please add a Test Plan here.

      Description

      In eduServices there is a method saveGradeAndCommentForStudent. There should also be just a method like saveGradeForStudent that doesn't touch the comments if the comments don't need to be altered. Currently I didn't see such a method. This could improve a few places in Gradebook NG and the service where it retrieves the comments and saves them back again.

      The method should not do any selects to persist the comments. 

      • Adding an additional parameter onto the saveGradeAndCommentForStudent and saveGradesAndComments to prevent the method from actually saving the comments.
        or
      • Creating more separate methods like saveGrades/saveComments/saveGradeforStudent/saveCommentforStudent that have more specific functions rather than trying to do everything.
        or
      • Passing in some "special value" for the comment that makes it ignore it as a comment (Though I'm not sure what this would be . . . )

      This is the typical pattern I've seen where it was doing this in Gradebook

       				final String comment = getAssignmentGradeComment(Long.valueOf(assignmentId), studentUuid);
      . . .
      				this.gradebookService.saveGradeAndCommentForStudent(gradebook.getUid(), assignmentId, studentUuid,
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  steve.swinsburg Steve Swinsburg
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:

                    Git Source Code