Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-41383

iFrame embedding missing allowfullscreen attributes

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 12.5, 19.0
    • Fix Version/s: 12.7, 19.1, 20.0
    • Component/s: BasicLTI
    • Labels:
    • 19 status:
      Resolved
    • 12 status:
      Resolved
    • Test Plan:
      Hide
      1. User opens Warpwire video in LTI (sidebar) tool.
      2. User selects fullscreen option.
      3. Video expands only within frame. See example.
        Video should open fullscreen.
      Show
      User opens Warpwire video in LTI (sidebar) tool. User selects fullscreen option. Video expands only within frame. See example. Video should open fullscreen.

      Description

      Choosing fullscreen option on streaming media in Sakai does not perform fullscreen on Chrome 72 and other browsers.

      Fullscreen issue was resolved in several other places including SAK-29690 but not main.vm and chef_iframe.vm

      Here is a GitHub search that provides a reference to the files that are missing the fullscreen property:
      https://github.com/sakaiproject/sakai/search?q=wciframe&unscoped_q=wciframe

      The following two files are lacking the full-screen attribute necessary to launch video streaming (Warpwire) in a fullscreen.

      1. sakai/basiclti/web-ifp/src/bundle/vm/main.vm
      2. sakai/web/web-tool/tool/src/webapp/vm/web/chef_iframe.vm
      ‚Äč
      Both should have the allowfullscreen attribute.

      Media streaming vendor (Warpwire) generally allows the following attributes (and it is the newer standard for embeds that things are moving):
      <.... allow="autoplay; encrypted-media; fullscreen;" allowfullscreen ...

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                ottenhoff Sam Ottenhoff
                Reporter:
                chrislorch Chris Lorch
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration