Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-41637

GB: In a GB with categories, bulk edit allows the instructor to select release to student and include in grade calcs even if the item is not in a category

    XMLWordPrintable

    Details

    • 19 status:
      Verified
    • Test Plan:
      Hide
      1. Create a couple of categories in a Gradebook
      2. Add several Gradebook items, putting some in the categories selecting Save and Release/Include in course grade..
      3. Create at least one item that is not in a category, no release to student/include in course grade
      4. Add some grades to all gb items
        Current behavior:
      5. Click bulk edit and check release to student and include in course grade for the gb item that is not categorized
      6. Click Save Changes
      7. Notice the uncategorized item is not included in the course grade
      8. Click bulk edit - notice the checkbox to include in course grade is checked for the uncategorized item

      Expected behavior: if the checkbox is not valid for the item, it should be disabled until that item is valid to be included in the course grade

      Show
      Create a couple of categories in a Gradebook Add several Gradebook items, putting some in the categories selecting Save and Release/Include in course grade.. Create at least one item that is not in a category, no release to student/include in course grade Add some grades to all gb items Current behavior: Click bulk edit and check release to student and include in course grade for the gb item that is not categorized Click Save Changes Notice the uncategorized item is not included in the course grade Click bulk edit - notice the checkbox to include in course grade is checked for the uncategorized item Expected behavior: if the checkbox is not valid for the item, it should be disabled until that item is valid to be included in the course grade

      Description

      In a GB with categories, if there are items not in a category, they can't be included in the course grade. Using the bulk edit option, the instructor can click to include the items in the course grade and the checkmark sticks. Looking at the gradebook again, though, you can see the item is not included in the course grade. Open up bulk edit again and you can see the checkmarks are still there.

      I think if a gradebook item is not eligible to be included in the course grade, then the checkbox should probably be disabled in bulk edit.

      There are errors for any bulk edit in the server logs (SAK-41629 ), but here are the values for one of the non-categorized items that were checked to release to student and be counted in the course grade:

      05-Apr-2019 21:22:34.837 ERROR [http-nio-20013-exec-14] org.sakaiproject.gradebookng.tool.panels.BulkEditItemsPanel.onSubmit Bulk edit assignment: Assignment(name=Item 8, id=250, points=20.0, dueDate=null, externallyMaintained=false, externalId=null, externalAppName=null, externalData=null, released=false, sortOrder=18, counted=false, categoryName=null, weight=null, ungraded=false, extraCredit=false, categoryExtraCredit=false, categoryId=null, categoryOrder=null, categorizedSortOrder=null, scaleGrades=false)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  a.fish@lancaster.ac.uk Adrian Fish
                  Reporter:
                  agschmidt Andrea Schmidt
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code