Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-41870

Google Tag Manager: Implement suggestions from tag assistant

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 19.1, 20.0 [Tentative]
    • Fix Version/s: 20.0 [Tentative]
    • Component/s: Portal
    • Labels:
    • 19 status:
      Please Merge
    • Test Plan:
      Hide

      This change requires a local environment or using the experimental server.

      1. Configure the google tag manager using a random code like GTM-XXXXXX, see the parent Jira.
      2. Install Google Tag Assistant extension in Chrome.
      3. Access Sakai, it should report problems (tags not in place, see before image).
      4. If everything looks good, you'll see a green icon (See after image).
      Show
      This change requires a local environment or using the experimental server. Configure the google tag manager using a random code like GTM-XXXXXX, see the parent Jira. Install Google Tag Assistant extension in Chrome. Access Sakai, it should report problems (tags not in place, see before image). If everything looks good, you'll see a green icon (See after image).

      Description

      The Google tag assistant extension reports implementation issues because the script is not located inside the head and the noScript is not in the body. This PR puts the scripts in the right place, verified with the tag assistant extension.

      Before:

       

      After:

       

        Gliffy Diagrams

          Attachments

          1. KO.jpg
            KO.jpg
            55 kB
          2. OK.jpg
            OK.jpg
            30 kB

            Issue Links

              Activity

                People

                • Assignee:
                  farreri Miguel Pellicer
                  Reporter:
                  farreri Miguel Pellicer
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code