Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-41879

Should implement findSubmissionForUsers to batch retrieve assignment submissions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 12.6, 19.1
    • Fix Version/s: 12.7, 19.2, 20.0 [Tentative]
    • Component/s: Assignments
    • Labels:
      None
    • 19 status:
      Resolved
    • 12 status:
      Resolved
    • Test Plan:
      Hide

      General regression testing: create a few different types of assignments in site (e.g., group submission, peer review, gradebook-linked) and test the various types of submissions (e.g., student submission, instructor submitting as student, upload all). Finally, make sure re-submission still working.

      Testing for speed: Probably need 2000 users and at least 1 submission each, which is how we experience this in 12.6 at ND.

      Show
      General regression testing: create a few different types of assignments in site (e.g., group submission, peer review, gradebook-linked) and test the various types of submissions (e.g., student submission, instructor submitting as student, upload all). Finally, make sure re-submission still working. Testing for speed: Probably need 2000 users and at least 1 submission each, which is how we experience this in 12.6 at ND.

      Description

      Calling findSubmissionForUser thousands of times in a big class is very inefficient.

      Should refactor to batch fetch the thousands of submissions in one call.

      2053             if (!rvUsers.isEmpty()) {
      2054                 for (User user : rvUsers) {
      2055                     AssignmentSubmission submission = assignmentRepository.findSubmissionForUser(assignment.getId(), user.getId());
      2056
      2057                     if (submission != null) {
      2058                         rv.put(user, submission);
      

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ern Earle R Nietzel
                  Reporter:
                  ottenhoff Sam Ottenhoff
                • Votes:
                  2 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code