Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42242

Add error checking for missing oidc redirect and launch endpoint if LTI 1.3 launches are selected

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 19.3, 20.0
    • Component/s: BasicLTI
    • Labels:
      None
    • 19 status:
      Resolved
    • Test Plan:
      Hide

      Follow the instructions to set up an LTI Advantage tool in Sakai: 

      https://github.com/sakaiproject/sakai/blob/master/basiclti/basiclti-docs/resources/docs/Advantage_TestPlan.xls

      Make various mistakes putting bad and / or blank values in the LTI13 fields and attempt launches and make sure the error messages at least lead to an understanding of what is wrong instead of 500 errors or tracebacks.

      For example leave the OIDC Initiation endpoint blank and leave the redirect end point blank.   There should be an error message that tells what is wrong instead of being cryptic.

      Show
      Follow the instructions to set up an LTI Advantage tool in Sakai:  https://github.com/sakaiproject/sakai/blob/master/basiclti/basiclti-docs/resources/docs/Advantage_TestPlan.xls Make various mistakes putting bad and / or blank values in the LTI13 fields and attempt launches and make sure the error messages at least lead to an understanding of what is wrong instead of 500 errors or tracebacks. For example leave the OIDC Initiation endpoint blank and leave the redirect end point blank.   There should be an error message that tells what is wrong instead of being cryptic.

      Description

      Add some error checking if required values for LTI 1.3 launches are missing instead of falling through the code and doing something that leaves the user with an error message that is not informative.

        Gliffy Diagrams

          Zeplin

            Attachments

            1. SAK-42242-500-Error.png
              198 kB
              Charles Severance
            2. SAK-42242-Better.png
              186 kB
              Charles Severance

              Activity

                People

                Assignee:
                csev Charles Severance
                Reporter:
                csev Charles Severance
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration