Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42375

LTI: Add content (shopping cart) in rich text editor and clicking OK after selection produces console errors

    XMLWordPrintable

    Details

    • Test Plan:
      Hide

      You will need to open the browser console to see the errors

      1. Open your browser console
      2. Go to Site Info -> External Tools and install an LTI 1.1 tool:
      3. Check the following boxes:
        • "Allow tool title to be changed"
        • "Allow Launch URL to be changed"
        • Send names
        • Send email
        • "Allow the tool to be used from the rich content editor to select content"
        • "Allow external tool to configure itself (the tool must support the IMS Content-Item message)"
      4. Do not check "Allow the tool to be launched as a link"
      5. Save the tool
      6. Click on Announcements -> Add
      7. In the rich text editor click the shopping cart icon
      8. Click the tool you added
      9. Click +Install for a tool displayed in the list
      10. Click Submit on the next screen
      11. The next screen has the blue "Install Content" button in the pop-up, but you will also see the bright green "OK" button: click OK

      Currently you will see error messages in the browser console

      Show
      You will need to open the browser console to see the errors Open your browser console Go to Site Info -> External Tools and install an LTI 1.1 tool: Name the tool "TsugiCloud Store" Use the URL:  https://test.tsugicloud.org/tsugi/lti/store/ with a key of 12345 and secret of secret. Check the following boxes: "Allow tool title to be changed" "Allow Launch URL to be changed" Send names Send email "Allow the tool to be used from the rich content editor to select content" "Allow external tool to configure itself (the tool must support the IMS Content-Item message)" Do not check "Allow the tool to be launched as a link" Save the tool Click on Announcements -> Add In the rich text editor click the shopping cart icon Click the tool you added Click +Install for a tool displayed in the list Click Submit on the next screen The next screen has the blue "Install Content" button in the pop-up, but you will also see the bright green "OK" button: click OK Currently you will see error messages in the browser console

      Description

      Clicking the shopping cart in the rich text editor, then selecting Install > Submit for a tool, the next screen displays an "Install Content" button inside the popup, but the OK button is bright green and grabs the user's attention. Clicking the "OK" button instead of the "Install Content" inside the pop-up causes errors to display in the console.

      The user can click "Install Content" afterward and the tool installs, and most users would not have their browser console open, so it would just seem like the "OK" is not working.

      Suggestion: Disable the OK button (if possible) when installing tools since the user can always cancel if they change their mind. They cannot install without clicking the "Install Content" button.

      Console errors:

      plugin.js?t=J5S8:35 Uncaught DOMException: Blocked a frame with origin "https://trunk-mysql.nightly.sakaiproject.org" from accessing a cross-origin frame.
       at CKEDITOR.dialog.onOk ([https://trunk-mysql.nightly.sakaiproject.org/library/editor/ckextraplugins/contentitem/plugin.js?t=J5S8:35:61])
       at CKEDITOR.dialog.<anonymous> ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:603:62])
       at CKEDITOR.dialog.l ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:10:224])
       at CKEDITOR.dialog.fire ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:12:47])
       at button.onClick ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:626:209])
       at button.<anonymous> ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:565:264])
       at button.l ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:10:224])
       at button.fire ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:12:47])
       at button.click ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:564:305])
       at CKEDITOR.dom.element.<anonymous> ([https://trunk-mysql.nightly.sakaiproject.org/library/webjars/ckeditor/4.12.1/full/ckeditor.js?version=ba4a6457:556:40])
       onOk @ plugin.js?t=J5S8:35
       (anonymous) @ ckeditor.js?version=ba4a6457:603
       l @ ckeditor.js?version=ba4a6457:10
       (anonymous) @ ckeditor.js?version=ba4a6457:12
       onClick @ ckeditor.js?version=ba4a6457:626
       (anonymous) @ ckeditor.js?version=ba4a6457:565
       l @ ckeditor.js?version=ba4a6457:10
       (anonymous) @ ckeditor.js?version=ba4a6457:12
       click @ ckeditor.js?version=ba4a6457:564
       (anonymous) @ ckeditor.js?version=ba4a6457:556
       l @ ckeditor.js?version=ba4a6457:10
       (anonymous) @ ckeditor.js?version=ba4a6457:12
       (anonymous) @ ckeditor.js?version=ba4a6457:72
      

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                csev Charles Severance
                Reporter:
                agschmidt Andrea Schmidt
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Git Source Code