Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42418

Sitestats entity providers run systemwide predefined reports across all sites

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 19.2, 20.0 [Tentative]
    • Fix Version/s: 19.3, 20.0 [Tentative]
    • Component/s: Sitestats
    • Labels:
      None
    • 19 status:
      Verified
    • Test Plan:
      Hide
      1. Go to Sitestats Admin in Admin Workspace.
      2. Click on "Admin Reports" tab
      3. Add a new report under the "Reports Predefined reports..." section to create a systemwide report.
      4. Make sure you have some events to report on in at least two sites.
      5. Go to /direct/sitestats/runreport/[a siteID here].json?id=[the id of the report you made]  (use /direct/sitestats/listreports/[a siteID here]|.json to find the report ID).

      You should only see events for the [a siteID here] site. 

      Show
      Go to Sitestats Admin in Admin Workspace. Click on "Admin Reports" tab Add a new report under the "Reports Predefined reports..." section to create a systemwide report. Make sure you have some events to report on in at least two sites. Go to /direct/sitestats/runreport/ [a siteID here] .json?id= [the id of the report you made]   (use /direct/sitestats/listreports/ [a siteID here] |.json to find the report ID). You should only see events for the [a siteID here] site. 

      Description

      When a system-wide report created in Sitestats Admin (i.e. a "Predefined reports, available for all sites") is run from /direct/sitestats/runreport it does not get a siteId set for it in its ReportDef.reportParams.  If that field is null, it tries to run the report across all sites.

      First, that's bad because the results are wrong, second it's bad because its accessing data from sites the user doesn't have permissions for, and finally it's bad because on a Sakai instance with many sites, it will just bog down and never return any results (which I guess mitigates the previous two problems).

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                ansorgej John Ansorge
                Reporter:
                ansorgej John Ansorge
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Git Source Code