Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42491

LTI 1.1: trim spaces from URL, key and secret fields

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Awaiting Review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 19.3, 20.0 [Tentative]
    • Fix Version/s: None
    • Component/s: BasicLTI
    • Labels:
      None
    • Test Plan:
      Hide
      1. Log in as an admin
      2. Click on Administration Workspace -> External Tools
      3. Click Install LTI 1.x Tool
      4. Fill in the following, adding a space after each entry:
      5. I checked the following:
        • Send Names to the External Tool
        • Send Email Addresses to the External Tool
        • Allow External Tool to return grades
        • Allow External Tool to create grade columns
        • Provide Roster to External Tool
        • Allow External Tool to store setting data
        • Allow the tool to be launched as a link (this is typically true for most tools)
      6. Click on Site Info -> Manage Tools
      7. Scroll down to the bottom and look under External Tools
      8. Select the tool, finish adding it to the site
      9. Launch the tool and click on Test Sakai Roster API

      Verify the tool loads correctly

      Show
      Log in as an admin Click on Administration Workspace -> External Tools Click Install LTI 1.x Tool Fill in the following, adding a space after each entry: Launch URL: https://www.tsugi.org/lti-test/tool.php Key: 12345 Secret: secret I checked the following: Send Names to the External Tool Send Email Addresses to the External Tool Allow External Tool to return grades Allow External Tool to create grade columns Provide Roster to External Tool Allow External Tool to store setting data Allow the tool to be launched as a link (this is typically true for most tools) Click on Site Info -> Manage Tools Scroll down to the bottom and look under External Tools Select the tool, finish adding it to the site Launch the tool and click on Test Sakai Roster API Verify the tool loads correctly

      Description

      Modified Jira subject, description and test plan. The problem is when a user copies and pastes the URL, key and secret for an LTI tool, there's risk of an added space which will cause a 500 error if the url has an added space, and fail if the key/secret have an added space when the user tries to launch the tool.

       

       

       

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                csev Charles Severance
                Reporter:
                agschmidt Andrea Schmidt
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Git Source Code