Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42590

Gradebook > Adding comments sometimes appears not to work

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 19.3, 20.0
    • Fix Version/s: 19.4, 20.0, 21.0 [Tentative]
    • Component/s: Gradebook
    • Labels:
      None
    • 20 status:
      Verified
    • 19 status:
      Resolved
    • Test Plan:
      Hide
      1. set up an external gradebook item (assignments, samigo, etc.)
      2. go to gradebook, add a comment for a student in the external gradebook item column
      3. provide some text; Save
      4. Result (sometimes):
        1. The modal dialogue doesn't go away fully, you are left with the title and an 'x' (see screenshot 1)
        2. after manually closing the dialog, the respective cell in the gradebook doesn't receive the icon indicating there's a comment
        3. if you click add/edit comment again, you'll see your text
        4. if you open the browser's console output, you'll see the JavaScript error in the description of this ticket
      Show
      set up an external gradebook item (assignments, samigo, etc.) go to gradebook, add a comment for a student in the external gradebook item column provide some text; Save Result (sometimes): The modal dialogue doesn't go away fully, you are left with the title and an 'x' (see screenshot 1) after manually closing the dialog, the respective cell in the gradebook doesn't receive the icon indicating there's a comment if you click add/edit comment again, you'll see your text if you open the browser's console output, you'll see the JavaScript error in the description of this ticket

      Description

      I encountered this problem today while testing something unrelated. Unfortunately, I haven't found concrete steps to reproduce as sometimes it works and sometimes it doesn't.

      Here's the actions I took:

      1. set up an external gradebook item (assignments, samigo, etc.)
      2. go to gradebook, add a comment for a student in the external gradebook item column
      3. provide some text; Save
        • The comment I used was "Where's your work?", perhaps the apostrophe has something to do with the problem, it's repeated in the JavaScript error output (below)
      4. Result (sometimes):
        1. The modal dialogue doesn't go away fully, you are left with the title and an 'x' (see screenshot 1)
        2. after manually closing the dialog, the respective cell in the gradebook doesn't receive the icon indicating there's a comment
        3. if you click add/edit comment again, you'll see your text
        4. if you open the browser's console output, you'll see the following JavaScript error:
      Wicket.Ajax:  Wicket.Ajax.Call.processEvaluation: Exception evaluating javascript: SyntaxError: missing ) after argument list, text: (function(){GbGradeTable.saveNewPrediction('Where's your work?');})();(function(){var win;
      try {
      	win = window.parent.Wicket.Window;
      } catch (ignore) {
      }
      if (typeof(win) == "undefined" || typeof(win.current) == "undefined") {
        try {
           win = window.Wicket.Window;
        } catch (ignore) {
        }
      }
      if (win && win.current) {
       var close = function(w) { w.setTimeout(function() {
      		win.current.close();
      	}, 0);  };
      	try { close(window.parent); } catch (ignore) { close(window); }
      }})();
      

      If you refresh the gradebook, the icon in the cell appears as it should.

      Sometimes it works properly, sometimes it doesn't. I haven't identified what the root cause is, and I'm not sure if this affects 19.x as well.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  jcebellan Jose Cebellán (Entornos de Formación)
                  Reporter:
                  bjones86 Brian Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration