Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42646

Autosave should be upgraded again for 19/20

    XMLWordPrintable

    Details

    • Test Plan:
      Hide

      Ensure the autosave and wordcount functionality on the CKEditor still works.

      I created this guide which should assist with testing the autosave plugin.
      https://github.com/sakaiproject/sakai/wiki/Overriding-javascript-files-for-QA-testing

      Let me know if you have any questions.

      Show
      Ensure the autosave and wordcount functionality on the CKEditor still works. I created this guide which should assist with testing the autosave plugin. https://github.com/sakaiproject/sakai/wiki/Overriding-javascript-files-for-QA-testing Let me know if you have any questions.

      Description

      In SAK-40634, the CKEditor plugins for autosave and wordcount were switched to using the webjars rather than the ones we were building. This is a problem because this was actually a downgrade and probably caused some issues since many bugs have been fixed in master while a new tag hasn't been made for these projects.

      As I mentioned in my comment, we should either

      1. Revert SAK-40634 and go back to building off a recent version of master again
      2. Modify the webjars forks to use a tag from master rather than a version (similar to the webjars in Sakai did it)
      3. Get the author to more frequently tag the latest version and get new webjars created off of that.

      I'd prefer option 3 but I think we could make it work with option 2 if that isn't happening.

      It looks like Wordcount is more up-to-date than Autosave, so just changing the scope of this.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration