Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42738

NPM install leaves modified files after failed Maven build

    XMLWordPrintable

    Details

    • 20 status:
      Resolved
    • Test Plan:
      Hide

      Please add a Test Plan here.

      Show
      Please add a Test Plan here.

      Description

      The webcomponents project runs some NPM goals. The "install" goal specifically will modify the following files if the Maven build fails:

      • webcomponents/tool/src/main/frontend/package-lock.json
      • webcomponents/tool/src/main/frontend/package.json

      This can be a problem if you're not aware of the issue and constantly checking if these files were modified after a failed build. The danger is that these unintended modifications can leak into commits if you're not extra careful.

      According to some articles online, NPM 5.7.0 introduced the "ci" command as an "additional way to achieve fast and reproducible builds...", and changing from "install" to "ci" resolves this issue.

      References:

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                bjones86 Brian Jones
                Reporter:
                bjones86 Brian Jones
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration