Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42846

Error message should indicate what the problem is, for example when not all fields are filled out

    Details

    • 20 status:
      Please Merge
    • Test Plan:
      Hide
      1. Create an assignment and send it to the gradebook
      2. Click on the gradebook
      3. Click on the Edit Item Details drop-down -> Message Students
      4. Select Ungraded Students
      5. Leave either the subject or body blank (or both)
      6. Click Send

      Expected behavior: A message  like "All fields are required" so the user knows why the message failed to send

       

      Show
      Create an assignment and send it to the gradebook Click on the gradebook Click on the Edit Item Details drop-down -> Message Students Select Ungraded Students Leave either the subject or body blank (or both) Click Send Expected behavior: A message  like "All fields are required" so the user knows why the message failed to send  

      Description

      If the user neglects to fill out a field in the pop-up, the message displayed at the bottom just states "Failed to send messages."

      It would be better to have something like "All fields are required" so the user knows they need to fill out everything.

      If the user neglects to enter a subject or a body or both, "Failed to send messages." displays.

      There is also a console error:

      https://trunk-mysql.nightly.sakaiproject.org/direct/gbng/messageStudents.json 400https://trunk-mysql.nightly.sakaiproject.org/direct/gbng/messageStudents.json 400sendMessage @ sakai-submission-messager.js:77handleEvent @ parts.ts:480EventPart.__boundHandleEvent @ parts.ts:438

      Found in server logs:

      02-Dec-2019 20:13:59.014 INFO [http-nio-20013-exec-25] org.sakaiproject.entitybroker.util.servlet.DirectServlet.dispatch Could not process entity: /gbng (400)[null]: Cannot execute custom action (messageStudents): Illegal arguments: You must supply siteId, assignmentId, subject and body (rethrown)

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  a.fish@lancaster.ac.uk Adrian Fish
                  Reporter:
                  agschmidt Andrea Schmidt
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration