Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-42850

Console error if previous message was not sent and pop-up closed with 'x'

    Details

    • 20 status:
      Verified
    • Test Plan:
      Hide
      1. With the browser console open...
      2. Create an assignment and send it to the gradebook
      3. Click on the gradebook
      4. Click on the Edit Item Details drop-down -> Message Students
      5. Select Ungraded Students
      6. Close the pop-up using the 'x' in the right upper corner
      7. Click the drop-down again to Message Students
      8. Select All Students
      9. Enter a subject and message
      10. Click Send

      Expected behavior: no browser console error

      Show
      With the browser console open... Create an assignment and send it to the gradebook Click on the gradebook Click on the Edit Item Details drop-down -> Message Students Select Ungraded Students Close the pop-up using the 'x' in the right upper corner Click the drop-down again to Message Students Select All Students Enter a subject and message Click Send Expected behavior: no browser console error

      Description

      Closing the pop-up with the 'x', then clicking to message students again creates a console error when clicking Send. The message does get sent, but maybe the form needs a 'Cancel' button if the instructor decides not to send the message?

      jquery.js:253 Uncaught Error: cannot call methods on dialog prior to initialization; attempted to call method 'destroy'
      at Function.error (jquery.js:253)
      at HTMLDivElement.<anonymous> (jquery-ui.min.js?version=1908a373:6)
      at Function.each (jquery.js:370)
      at a.fn.init.each (jquery.js:137)
      at a.fn.init.t.fn.<computed> [as dialog] (jquery-ui.min.js?version=1908a373:6)
      at HTMLDivElement.<anonymous> (gradebook-gbgrade-table.js?version=1908a373:1243)
      at HTMLDivElement.dispatch (jquery.js:5226)
      at HTMLDivElement.r.handle (jquery.js:4878)
      at sakai-submission-messager.js:83
      error @ jquery.js:253
      (anonymous) @ jquery-ui.min.js?version=1908a373:6
      each @ jquery.js:370
      each @ jquery.js:137
      t.fn.<computed> @ jquery-ui.min.js?version=1908a373:6
      (anonymous) @ gradebook-gbgrade-table.js?version=1908a373:1243
      dispatch @ jquery.js:5226
      r.handle @ jquery.js:4878
      (anonymous) @ sakai-submission-messager.js:83
      setTimeout (async)
      (anonymous) @ sakai-submission-messager.js:83
      Promise.then (async)
      sendMessage @ sakai-submission-messager.js:78
      handleEvent @ parts.ts:480
      EventPart.__boundHandleEvent @ parts.ts:438

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  a.fish@lancaster.ac.uk Adrian Fish
                  Reporter:
                  agschmidt Andrea Schmidt
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration