Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-43483

AntiSamy should allow the controlsList attribute in video tags

    XMLWordPrintable

    Details

    • 20 status:
      Verified
    • 19 status:
      Verified
    • Test Plan:
      Hide
      1. Create a quiz with a short answer/essay question
      2. Enable the rich text editor
      3. Add a movie
      4. Click on Advanced tab and verify Allow download? = No
      5. Click on Video Info tab and check the box: Show controls
      6. Save the question then publish the quiz
      7. As a student, take the quiz
      8. Right-click the video and select to save the video

      Currently, even with allow download = No, the video can be downloaded because the controlslist="nodownload" is stripped by all 3 browsers.

      Show
      Create a quiz with a short answer/essay question Enable the rich text editor Add a movie Click on Advanced tab and verify Allow download? = No Click on Video Info tab and check the box: Show controls Save the question then publish the quiz As a student, take the quiz Right-click the video and select to save the video Currently, even with allow download = No, the video can be downloaded because the controlslist="nodownload" is stripped by all 3 browsers.

      Description

      Not sure if there's anything that can be done about this, but when adding a video in the rich text editor, by default the ability to download the video is set to "No". 

      When the question is saved, a message pops up stating some html tags/attributes are not allowed and have been removed.

      The video plays fine on Win10: Chrome, Edge and Firefox, but students are able to download the video.

       

      Code when inserting movie:
      <div class="ckeditor-html5-video" style="text-align:center">
      <video controls="controls" controlslist="nodownload" src="https://trunk-mysql.nightly.sakaiproject.org/access/content/group/c3fdc948-945d-4b2c-918e-14690d41aea5/group_folders.mp4"> </video>
      </div>

      Code after saving question:
      <div class="ckeditor-html5-video" style="text-align:center">
      <video controls="controls" src="https://trunk-mysql.nightly.sakaiproject.org/access/content/group/c3fdc948-945d-4b2c-918e-14690d41aea5/group_folders.mp4"> </video>
      </div>

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  farreri Miguel Pellicer
                  Reporter:
                  agschmidt Andrea Schmidt
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration