Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-43709

Remove / adjust LTI data model fields for Sakai-21

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 21.0
    • Component/s: BasicLTI
    • Labels:
      None
    • Test Plan:
      Hide

      The only change to test is in the "Add new LTI 1.1 Tool" in the External Tools Admin.   Before the change, the keyset_url will be a textarea (see the attached screen shot) and after the change, the input area will be type="text" input like the client_id field.

      Show
      The only change to test is in the "Add new LTI 1.1 Tool" in the External Tools Admin.   Before the change, the keyset_url will be a textarea (see the attached screen shot) and after the change, the input area will be type="text" input like the client_id field.

      Description

      This Jira should not be back-ported to Sakai-20 - the changes in this Jira are not needed in those systems and the data model for -20 are sufficient already and need no change.

      The changes are to the LTIService.java code

      (1) remove lti13_tool_kid - This was put in place to allow for a simple database caching of the most recently retrieved public key from a keyset.  The keyset was not implemented until SAK-43698 and that implementation does not use this field because public key caching in Sakai-21 will be done in the cluster-cache and not the database for lots of reasons.

      (2) Change the length of lti13_keyset_url from 1M to 1024 - this will make the UI look better.  Since this is a text field it does not have to be made smaller in the database - but it can be made smaller.

       

       

       

        Gliffy Diagrams

          Zeplin

            Attachments

            1. keyset_url.gif
              keyset_url.gif
              14 kB
            2. SAK-43709-After.png
              SAK-43709-After.png
              223 kB
            3. SAK-43709-Before.png
              SAK-43709-Before.png
              227 kB
            4. SAK-43709-big-text-box.png
              SAK-43709-big-text-box.png
              28 kB

              Issue Links

                Activity

                  People

                  Assignee:
                  csev Charles Severance
                  Reporter:
                  csev Charles Severance
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration