Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-43710

Remove support for SHA256 Launches in Sakai-21

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 21.0 [Tentative]
    • Component/s: BasicLTI
    • Labels:
      None
    • Conversion Script Required:
      Yes
    • Test Plan:
      Hide

      There is no way to test this other than do the LTI QA and make sure no regressions are introduced.  The field and drop down have been hidden in the insert new tool and edit tool since Sakai-20.

      Show
      There is no way to test this other than do the LTI QA and make sure no regressions are introduced.  The field and drop down have been hidden in the insert new tool and edit tool since Sakai-20.

      Description

      Back in ancient history in between LTI 2.0 and LTI Advantage, the working group came up with the idea to "improve" LTI 1.1 - it never really happened in the market and with LTI Advantage using JWTs there is little benefit in breaking LTI 1.1 by doing SHA256 launches.

      https://github.com/LtiLibrary/LtiLibrary/issues/97

      So in Sakai-21, unless there is a good reason, support for SHA256 launches will be removed.

      It is a pretty simple change - just remove one line from LTIService.java and a few translation strings - and poof! it is gone.

      There is no reason to back-port this to Sakai-20.

      A conversion script is not essential - but why not drop an unused column in -21 if we can.  This parch will remove the field form the UI and launch code - the column would simply be unused going forward.

      If you want to see if you have every used SHA256 on any tool eve in the history of your Sakai run this query on your database:

      SELECT count( * )  FROM `lti_tools` where sha256 = 1;

       

       

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                csev Charles Severance
                Reporter:
                csev Charles Severance
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration