Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-43715

Fix Cookie Issue When Error Happens on LTI Advantage Deep Link Return

    XMLWordPrintable

    Details

    • 20 status:
      Please Merge
    • 19 status:
      Please Merge
    • Test Plan:
      Hide

      Set up an LTI Advantage Content Item tool and verify correct functioning when running the "App Store" sequence.  Then change the URL for the keyset to something incorrect like:

      http://localhost:8888/py4e/tsugi/lti/keysetx

      Then go through the App Store sequence - without this fix, at the moment where the App Store comes back to Sakai - it will encounter an error and instead of seeing the error you get a login screen (does not last too long).  With the fix you will see the error.

      Images of both scenarios are attached.

       

      Show
      Set up an LTI Advantage Content Item tool and verify correct functioning when running the "App Store" sequence.  Then change the URL for the keyset to something incorrect like: http://localhost:8888/py4e/tsugi/lti/keysetx Then go through the App Store sequence - without this fix, at the moment where the App Store comes back to Sakai - it will encounter an error and instead of seeing the error you get a login screen (does not last too long).  With the fix you will see the error. Images of both scenarios are attached.  

      Description

      When the Deep Link (formerly known as Content Item) flow encounters an error, we lose the cookie and you see the login screen (image attached).  The normal flow has extra code to restore the cookie but the error flow was missing this bit.  Of course this problem only occurs when you are testing using an LMS and tool on different domains (i.e. localhost happily passes the cookie around).

      This will need to be back-ported to Sakai-19 and -20 but make sure to back-port SAK-43698 first.  This does not depend on SAK-43698 but the addition of the keyset URL feature makes it more likely that an error might happen because of bad input or a bad keyset URL.  Before the keyset URL it was rather rare to have an error occur at this particular phase of the Deep Link protocol.   So it is good to this back to Sakai-19 and Sakai-20 when moving SAK-43698.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  csev Charles Severance
                  Reporter:
                  csev Charles Severance
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration