Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-43835

Using non-english default locale results in empty portal.locale for english

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 20.1, 21.0 [Tentative]
    • Fix Version/s: 21.0 [Tentative]
    • Component/s: Kernel
    • Labels:
      None
    • 20 status:
      Please Merge
    • Test Plan:
      Hide

      In an instance with non-english default locale go to preferences and select any english locale en_US for example. Then go to Roster and you should be able to see UI in english.

      You could also check in a community nightly that roster change UI translations selecting different ones y user preferences.

       

      Show
      In an instance with non-english default locale go to preferences and select any english locale en_US for example. Then go to Roster and you should be able to see UI in english. You could also check in a community nightly that roster change UI translations selecting different ones y user preferences.  

      Description

      In recent versions of sakai the portal.locale javascript object is needed to determine the user locale. This object could be calculated in ResourceLoader and in instances with a non-english default locale you get empty string with "en" locale selected:

       

      https://github.com/sakaiproject/sakai/blob/master/kernel/kernel-util/src/main/java/org/sakaiproject/util/ResourceLoader.java#L433-L440

       

      I'm wondering why this locale is set to "" only for NON-English default locales but i think this code is not needed anymore.

       

       

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  maintenanceteam Core Team
                  Reporter:
                  jjmerono@um.es Juan José Meroño Sánchez
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration