[SAK-44067] SAMIGO - Can't edit calculated questions with comma on the solution - Sakai

Details

Type: Bug
Status: CLOSED
Priority: Major
Resolution: Fixed
Affects Version/s: 19.5, 20.2, 21.0
Fix Version/s: 19.6, 20.2, 21.0
Component/s: Tests & Quizzes (Samigo)
Labels:
None

20 status:
Verified
19 status:
Verified

Test Plan:
Hide

1. Go to Tests & Quizzes
2. Click Question Pools
3. Click Add New Pool
4. Pool Name and Save
5. Click on the pool
6. Click Add Question
7. Select Calculated Question and Save
8. Fill Instructions

En un determinado barrio hay tres supermercados, el [[{a}*100]]% de las personas compra en el supermercado A, el [[{b}*100]]% en el supermercado B y el [[{c}*100]]% en el C. El [[round(min({a},{b})*100*{i1},0 )]]% compra en el supermercado A y B, el [[round(min(round(min({a},{b})*100*{i1},0 ), {c}*100)*{i2},0)]]% en los supermercados A y C y los clientes de B no lo son de C. ¿Cuál es la probabilidad de que un individuo escogido al azar compre sólo en el supermercado A? {{sol}}%

9. Click Extract Variables, Calculations, and Formulas from Question Text

a b c i1 i2 -> Example: Min 0.3 and Max 0.7. Decimal Places 2

10. Fill sol

{a}*100-round(min({a},{b})*100*{i1},0 )-round(min(round(min({a},{b})*100*{i1},0 ), {c}*100)*{i2},0)

11. Click Save
12. Try edit question

Test & Quizzes is restarted and an error appears on log.
Show
1. Go to Tests & Quizzes 2. Click Question Pools 3. Click Add New Pool 4. Pool Name and Save 5. Click on the pool 6. Click Add Question 7. Select Calculated Question and Save 8. Fill Instructions En un determinado barrio hay tres supermercados, el [[{a}*100]]% de las personas compra en el supermercado A, el [[{b}*100]]% en el supermercado B y el [[{c}*100]]% en el C. El [[round(min({a},{b})*100*{i1},0 )]]% compra en el supermercado A y B, el [[round(min(round(min({a},{b})*100*{i1},0 ), {c}*100)*{i2},0)]]% en los supermercados A y C y los clientes de B no lo son de C. ¿Cuál es la probabilidad de que un individuo escogido al azar compre sólo en el supermercado A? {{sol}}% 9. Click Extract Variables, Calculations, and Formulas from Question Text a b c i1 i2 -> Example: Min 0.3 and Max 0.7. Decimal Places 2 10. Fill sol {a}*100-round(min({a},{b})*100*{i1},0 )-round(min(round(min({a},{b})*100*{i1},0 ), {c}*100)*{i2},0) 11. Click Save 12. Try edit question Test & Quizzes is restarted and an error appears on log.

Description

See attached image and testing plan

04-ago-2020 09:44:41.589 ERROR [ajp-nio-127.0.0.1-8014-exec-8] org.sakaiproject.tool.assessment.ui.listener.author.ItemModifyListener.populateItemBean Could not populate ItemBean
java.lang.StringIndexOutOfBoundsException: String index out of range: -79
	at java.lang.String.substring(String.java:1967)
	at org.sakaiproject.tool.assessment.ui.listener.author.ItemModifyListener.populateItemTextForCalculatedQuestion(ItemModifyListener.java:767)
	at org.sakaiproject.tool.assessment.ui.listener.author.ItemModifyListener.populateItemBean(ItemModifyListener.java:271)
	at org.sakaiproject.tool.assessment.ui.listener.author.ItemModifyListener.processAction(ItemModifyListener.java:123)
	at javax.faces.event.ActionEvent.processListener(ActionEvent.java:96)
	at javax.faces.component.UIComponentBase.broadcast(UIComponentBase.java:839)
	at javax.faces.component.UICommand.broadcast(UICommand.java:315)
	at javax.faces.component.UIData.broadcast(UIData.java:1158)
	at javax.faces.component.UIViewRoot.broadcastEvents(UIViewRoot.java:870)
	at javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:1418)
	at com.sun.faces.lifecycle.InvokeApplicationPhase.execute(InvokeApplicationPhase.java:82)
	at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100)
	at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:201)
	at javax.faces.webapp.FacesServlet.service(FacesServlet.java:670)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:426)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:712)
	at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:459)
	at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:384)
	at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:312)
	at org.sakaiproject.jsf.util.SamigoJsfTool.dispatch(SamigoJsfTool.java:360)
	at org.sakaiproject.jsf2.util.JsfTool.doPost(JsfTool.java:250)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:660)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:712)
	at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:459)
	at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:352)
	at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:312)
	at org.sakaiproject.tool.impl.ActiveToolComponent$MyActiveTool.forward(ActiveToolComponent.java:508)
	at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1500)
	at org.sakaiproject.portal.charon.handlers.SiteHandler.doToolBuffer(SiteHandler.java:1262)
	at org.sakaiproject.portal.charon.handlers.SiteHandler.bufferContent(SiteHandler.java:1096)
	at org.sakaiproject.portal.charon.handlers.SiteHandler.doSite(SiteHandler.java:508)
	at org.sakaiproject.portal.charon.handlers.SiteHandler.doGet(SiteHandler.java:280)
	at org.sakaiproject.portal.charon.handlers.SiteHandler.doGet(SiteHandler.java:164)
	at org.sakaiproject.portal.charon.handlers.WorksiteHandler.doPost(WorksiteHandler.java:69)
	at org.sakaiproject.portal.charon.SkinnableCharonPortal.doPost(SkinnableCharonPortal.java:1173)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:660)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:475)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:541)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
	at org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:747)
	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:690)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
	at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:431)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1590)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.lang.Thread.run(Thread.java:748)
04-Aug-2020 09:44:41.593 ADVERTENCIA [ajp-nio-127.0.0.1-8014-exec-8] com.sun.faces.lifecycle.InvokeApplicationPhase.execute failed to populateItemBean.
	java.lang.RuntimeException: failed to populateItemBean.
		at org.sakaiproject.tool.assessment.ui.listener.author.ItemModifyListener.processAction(ItemModifyListener.java:125)
		at javax.faces.event.ActionEvent.processListener(ActionEvent.java:96)
		at javax.faces.component.UIComponentBase.broadcast(UIComponentBase.java:839)
		at javax.faces.component.UICommand.broadcast(UICommand.java:315)
		at javax.faces.component.UIData.broadcast(UIData.java:1158)
		at javax.faces.component.UIViewRoot.broadcastEvents(UIViewRoot.java:870)
		at javax.faces.component.UIViewRoot.processApplication(UIViewRoot.java:1418)
		at com.sun.faces.lifecycle.InvokeApplicationPhase.execute(InvokeApplicationPhase.java:82)
		at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100)
		at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:201)
		at javax.faces.webapp.FacesServlet.service(FacesServlet.java:670)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
		at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
		at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:426)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
		at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:712)
		at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:459)
		at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:384)
		at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:312)
		at org.sakaiproject.jsf.util.SamigoJsfTool.dispatch(SamigoJsfTool.java:360)
		at org.sakaiproject.jsf2.util.JsfTool.doPost(JsfTool.java:250)
		at javax.servlet.http.HttpServlet.service(HttpServlet.java:660)
		at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
		at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:712)
		at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:459)
		at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:352)
		at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:312)
		at org.sakaiproject.tool.impl.ActiveToolComponent$MyActiveTool.forward(ActiveToolComponent.java:508)
		at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1500)
		at org.sakaiproject.portal.charon.handlers.SiteHandler.doToolBuffer(SiteHandler.java:1262)
		at org.sakaiproject.portal.charon.handlers.SiteHandler.bufferContent(SiteHandler.java:1096)
		at org.sakaiproject.portal.charon.handlers.SiteHandler.doSite(SiteHandler.java:508)
		at org.sakaiproject.portal.charon.handlers.SiteHandler.doGet(SiteHandler.java:280)
		at org.sakaiproject.portal.charon.handlers.SiteHandler.doGet(SiteHandler.java:164)
		at org.sakaiproject.portal.charon.handlers.WorksiteHandler.doPost(WorksiteHandler.java:69)
		at org.sakaiproject.portal.charon.SkinnableCharonPortal.doPost(SkinnableCharonPortal.java:1173)
		at javax.servlet.http.HttpServlet.service(HttpServlet.java:660)
		at javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
		at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:475)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
		at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
		at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
		at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
		at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202)
		at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
		at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:541)
		at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:139)
		at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92)
		at org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:747)
		at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:690)
		at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
		at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
		at org.apache.coyote.ajp.AjpProcessor.service(AjpProcessor.java:431)
		at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
		at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
		at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1590)
		at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
		at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
		at java.lang.Thread.run(Thread.java:748)

Gliffy Diagrams

Zeplin

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

calc_question_spanish.gif
9 kB
14-Oct-2020 18:37

Issue Links

relates to

SAK-44744 SAMIGO - Wrong export when formulas includes more than one comma on a calculated question

CLOSED

SAMIGO - Can't edit calculated questions with comma on the solution

Details

Description

Gliffy Diagrams

Zeplin

Attachments

Attachments

Issue Links

Activity

People

Dates

Git Integration