Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-44102

@Transaction performance optimization with MessageBundleService

    XMLWordPrintable

    Details

    • 20 status:
      Resolved
    • 19 status:
      Resolved
    • Test Plan:
      Hide

      The text should be displayed correctly in pages in Sakai.

      Test simple changes in Message Bundle Manager.

      Test other languages.

      Show
      The text should be displayed correctly in pages in Sakai. Test simple changes in Message Bundle Manager. Test other languages.

      Description

      The class

      CachingMessageBundleServiceImpl extends MessageBundleServiceImpl

      is inherited and must declare it's Override methods with @Transactional this causes those annotated methods to be intercepted by spring and have them setup transaction for code path that is to come.
      Switching this class from inherited to a composition style relation can remove this overhead by moving the transaction interception logic to be after the cache check and avoid wasted time of setting up the transaction if the bundle is in fact cached.

      The reason this is an issue is because this code called so frequently in a single request.

      See attached screenshots

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  ern Earle R Nietzel
                  Reporter:
                  ern Earle R Nietzel
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration