Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-44125

Hiding rubrics grants all roles rubric.editor

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 19.4, 20.2, 21.0, 22.0 [Tentative]
    • Fix Version/s: 19.6, 20.2, 21.0, 22.0 [Tentative]
    • Component/s: Rubrics
    • Labels:
      None
    • 21 Status:
      Verified
    • 20 status:
      Verified
    • 19 status:
      Verified
    • Test Plan:
      Hide

      To test

      1. Add the Rubrics to the site
      2. Verify in Admin site's Realms for corresponding site that the site only has rubric.editor granted to Instructor role
      3. Returning to site Go into Site Info > Tool Order, and HIDE the Rubrics tool.
      4. Verify in Admin site's Realms for corresponding site that the site, all roles should remain the same
      5. Returning to site Go into Site Info > Tool Order, and UNHIDE the Rubrics tool.
      6. Verify in Admin site's Realms for corresponding site that the site, all roles should remain the same

      (Triage note: Added steps 5 & 6 to test plan to make sure unhiding doesn't trigger the issue)

      Show
      To test Add the Rubrics to the site Verify in Admin site's Realms for corresponding site that the site only has rubric.editor granted to Instructor role Returning to site Go into Site Info > Tool Order, and HIDE the Rubrics tool. Verify in Admin site's Realms for corresponding site that the site, all roles should remain the same Returning to site Go into Site Info > Tool Order, and UNHIDE the Rubrics tool. Verify in Admin site's Realms for corresponding site that the site, all roles should remain the same (Triage note: Added steps 5 & 6 to test plan to make sure unhiding doesn't trigger the issue)

      Description

      Hiding the Rubrics tool grants all roles rubric.editor permission, regardless of previous permissions.

      Tested on https://trunk-mysql.nightly.sakaiproject.org/

      To recreate, create a new course site. Then:

      1. Add the Rubrics to the site
      2. Verify in Admin site's Realms for corresponding site that the site only has rubric.editor granted to Instructor role
      3. Returning to site Go into Site Info > Tool Order, and HIDE the Rubrics tool.
      4. Verify in Admin site's Realms for corresponding site that the site, all roles will now have rubric.editor

      These actions will give all users rubrics.editor. Hard to see this as desired behaviour.
      Making the Rubrics tool visible does not restore the previous permissions.

      Screen recording attached.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

              is related to

              Bug - A problem which impairs or prevents functionality of the product. SAK-43138 Tools that are hidden from students by default (Statistics, Rubrics) should have hidden icon

              • Major - Major loss of function or need for functionality in production in the near future.
              • CLOSED
              relates to

              Bug - A problem which impairs or prevents functionality of the product. SAK-44728 Rubrics: Hiding, then unhiding the rubrics tool allows students to see and work with rubrics

              • Blocker - Blocks development and/or testing work, production could not run without this feature working correctly.
              • CLOSED

                Activity

                  People

                  Assignee:
                  a.fish@lancaster.ac.uk Adrian Fish
                  Reporter:
                  mclare Matt Clare
                  Votes:
                  2 Vote for this issue
                  Watchers:
                  11 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration