Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-44395

sakai-rubric-student-button is making excessive http calls on load

    XMLWordPrintable

    Details

    • 21 Status:
      Verified
    • 20 status:
      Verified
    • 19 status:
      Verified
    • Test Plan:
      Hide
      1. Create and assignment that is graded and assign a rubric
      2. Open the developer tools and goto network and filter xhr requests
      3. In the assignment list view, click the Grade link for the assignment
        1. failure = Notice all the identical http requests being made for each submission
        2. pass = Only a single ajax request should be made for the assignment and a single ajax request made if the rubric button is clicked
      Show
      Create and assignment that is graded and assign a rubric Open the developer tools and goto network and filter xhr requests In the assignment list view, click the Grade link for the assignment failure = Notice all the identical http requests being made for each submission pass = Only a single ajax request should be made for the assignment and a single ajax request made if the rubric button is clicked

      Description

      SakaiRubricStudentButton.setHidden is making an http request for every submission when it loads, maybe should look at delaying the http call until the button is actually clicked to avoid loading data needlessly.

       

      Another possible improvement maybe that only a single call is actually needed until the button is clicked since the "evaluatedItemId" is never used in the actual http call.

       

      SakaiRubricsHelpers.get("/rubrics-service/rest/rubric-associations/search/by-tool-item-ids", "Bearer " + this.token, { params: { toolId: this.toolId, itemId: this.entityId } }).then(data => {
      

       

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  agschmidt Andrea Schmidt
                  Reporter:
                  ern Earle R Nietzel
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration