Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-44413

Remove sakai.force.secure.url property and fix getServerUrl()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Won't Do
    • Affects Version/s: 21.0 [Tentative]
    • Fix Version/s: None
    • Component/s: Kernel
    • Labels:
      None
    • Test Plan:
      Hide

      When this is done - there will be no real external effect.

      An important test is to make sure to start Sakai with no value for serverUrl - it needs to default to http://localhost:8080 if the sakai.serverUrl is not set in sakai.properties

      For my testing, I ran the sakai-smoker.py test that retrieves 40000 urls - first I ran it without this fix to get a baseline and then ran it again with this fix - and compared the two runs - and nothing broke.

      Show
      When this is done - there will be no real external effect. An important test is to make sure to start Sakai with no value for serverUrl - it needs to default to http://localhost:8080 if the sakai.serverUrl is not set in sakai.properties For my testing, I ran the sakai-smoker.py test that retrieves 40000 urls - first I ran it without this fix to get a baseline and then ran it again with this fix - and compared the two runs - and nothing broke.

      Description

      This Jira will remove the sakai.force.url.secure that was introduced in SAK-21124 - this needs careful review and scrutiny.

      Created in:  https://github.com/sakaiproject/sakai/commit/807cc9807f0

      This will also change the ServerConfigutationService.getServerUrl() to always return the configured URL and ignore the thread local CURRENT_SERVER_URL

      This needs a lot of investigation and testing - This Jira will evolve as we learn more.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  csev Charles Severance
                  Reporter:
                  csev Charles Severance
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration