Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-44542

Site icon needs alt text

    XMLWordPrintable

    Details

    • Test Plan:
      Hide
      1. go to site info -> edit site information
      2. enter in a icon url
        1. or set some iconURLs and iconNames in sakai.properties
      3. save
      4. inspect the site icon html or view the page with a screen reader
      5. there isn't an "alt" text for the site icon
      Show
      go to site info -> edit site information enter in a icon url or set some iconURLs and iconNames in sakai.properties save inspect the site icon html or view the page with a screen reader there isn't an "alt" text for the site icon

      Description

      IncludePageNav.vm displays a site icon if it exists

      <img src="${sitePages.pageNavIconUrl}" alt="" class="img_site_toolmenu">
      

      it should include alt text.

      1) A simple idea could be to just set it to something like "Site Icon"

      2) Another idea could be to add a new property "iconName" to BaseSite.java, with a default of value of "Site Icon". However, setting it to a user specified value could be tricky...

      If the site type is Project, the user can only specify the icon URL, so in that case you'd set the icon name to the default. Or you'd have to add a way for the user to input a name.

      If the site type is Course, there are optional properties in sakai.properties to set the iconURLs, iconNames, iconSkins. In BaseSite.java, when the site object is constructed you could derive the name based on the saved iconURL compared to iconNames in sakai.properties. Or maybe you could set it the first time a new method site.getIconName() is called? But would that retain the value in the site cache? Or you could save the icon name to the database?

      This seems like a lot of work just for an "alt" text. Maybe it would be easiest (but less helpful) to just hard code it to "Site Icon"?

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                farreri Miguel Pellicer
                Reporter:
                austinUH Austin
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration