Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-44811

Further Improvements to Catch Content Blocked in Iframe

    XMLWordPrintable

    Details

    • 21 Status:
      Verified
    • 20 status:
      Verified
    • Test Plan:
      Hide

      Make sure debug is turned off (i.e. you are not seeing either "Continue to External Tool" or the JWT dump for LTI 1.3)

      Make sure you are on a server that is using https (i.e. not a local dev instance)

      Set up a tool configured properly for LTI 1.1 and LTI 1.3 - probably just use the https://sakai.tsugicloud.org - install one tool in lessons using Add Learning App.  Launch the tool and make sure it works in both LTI 1.1 and 1.3. 

      Then break the tool LTI 1.3 by editing it and changing "LTI 1.3 Tool OpenID Connect/Initialization Endpoint" and change https to http and save the tool. 

      Go into Lessons and attempt to add a Learning App.  If you watch the developer console, you will see the mixed content block happen - but in 5 seconds, Sakai will notice it and pop up an alert.  It can't be fixed- but Sakai now talks about it.  (screen shot)

      Also go and try to launch a tool you installed before you broke it - the same should happen.  It should fail but a message should come up.

      Show
      Make sure debug is turned off (i.e. you are not seeing either "Continue to External Tool" or the JWT dump for LTI 1.3) Make sure you are on a server that is using https (i.e. not a local dev instance) Set up a tool configured properly for LTI 1.1 and LTI 1.3 - probably just use the https://sakai.tsugicloud.org - install one tool in lessons using Add Learning App.  Launch the tool and make sure it works in both LTI 1.1 and 1.3.  Then break the tool LTI 1.3 by editing it and changing "LTI 1.3 Tool OpenID Connect/Initialization Endpoint" and change https to http and save the tool.  Go into Lessons and attempt to add a Learning App.  If you watch the developer console, you will see the mixed content block happen - but in 5 seconds, Sakai will notice it and pop up an alert.  It can't be fixed- but Sakai now talks about it.  (screen shot) Also go and try to launch a tool you installed before you broke it - the same should happen.  It should fail but a message should come up.

      Description

      This is a continuation of and expansion of SAK-44661 to catch more use cases where something goes wrong in an iframe (often blocking mixed content) and we end up with a blank screen.

      This Jira in particular catches some places where a Location header from an https page to an http page just stops dead with nothing except a console message.  This happens when Sakai is doing LTI Advantage launches and needs to redirect to the OIDC endpoint.

        Gliffy Diagrams

          Zeplin

            Attachments

            1. lti_1.1_url.gif
              lti_1.1_url.gif
              10 kB
            2. lti_1.3_url.gif
              lti_1.3_url.gif
              14 kB
            3. lti1.3_message.gif
              lti1.3_message.gif
              29 kB
            4. SAK-44811-Bad-Advantage-Install.png
              SAK-44811-Bad-Advantage-Install.png
              400 kB
            5. SAK-44811-Bad-Advantage-Launch.png
              SAK-44811-Bad-Advantage-Launch.png
              449 kB
            6. SAK-44811-No-More-Message.png
              SAK-44811-No-More-Message.png
              83 kB

              Issue Links

                Activity

                  People

                  Assignee:
                  csev Charles Severance
                  Reporter:
                  csev Charles Severance
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration