Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-45006

Should be able to disable the dark theme toggle separate of the dark theme

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 21.0, 22.0 [Tentative]
    • Fix Version/s: 21.0, 22.0 [Tentative]
    • Component/s: Library, Portal
    • Labels:
      None
    • 21 Status:
      Merged
    • Property addition/change required:
      Yes
    • Test Plan:
      Hide
      1. enable the new property ("portal.themes") and disable "portal.themes.switcher" (these are the default settings)
      2. ensure dark theme preference still works, including account preference saving (see SAK-44447 for test plan)
        • note: auto-detection is now controlled with a new property "portal.themes.autoDetectDark", which is disabled by default, so Sakai will no longer detect your OS dark mode to automatically set your Sakai theme by default
      3. disable the new "portal.themes" property
      4. ensure dark theme preferences default to light theme
      5. ensure the Themes preference tab disappears from Preferences
      6. ensure there is no theme toggle button in the account menu
      7. re-enable the new property ("portal.themes") and enable "portal.themes.switcher"
      8. ensure dark theme preference still works, including account preference saving (see SAK-44447 for test plan)
      9. ensure you can toggle the dark theme using the account menu toggle button
      10. enable the other new property "portal.themes.autoDetectDark"
      11. enable dark mode in your operating system on your device (steps vary per device and OS)
      12. refresh Sakai
      13. ensure the Gateway and any new accounts (that have never been logged into before) default to dark theme
      Show
      enable the new property ("portal.themes") and disable "portal.themes.switcher" (these are the default settings) ensure dark theme preference still works, including account preference saving (see SAK-44447 for test plan) note: auto-detection is now controlled with a new property "portal.themes.autoDetectDark", which is disabled by default, so Sakai will no longer detect your OS dark mode to automatically set your Sakai theme by default disable the new "portal.themes" property ensure dark theme preferences default to light theme ensure the Themes preference tab disappears from Preferences ensure there is no theme toggle button in the account menu re-enable the new property ("portal.themes") and enable "portal.themes.switcher" ensure dark theme preference still works, including account preference saving (see SAK-44447 for test plan) ensure you can toggle the dark theme using the account menu toggle button enable the other new property "portal.themes.autoDetectDark" enable dark mode in your operating system on your device (steps vary per device and OS) refresh Sakai ensure the Gateway and any new accounts (that have never been logged into before) default to dark theme

      Description

      The Sakai Dark theme was introduced in SAK-43981 and further refined in SAK-44447 and SAK-44900. Work is continuing in SAK-44629 to resolve any visual issues still lurking in tools.

      The preferred way to set your theme preference is through Preferences. There is currently no way to disable the account menu toggle without disabling themes.

      Change the property from "portal.themeswitcher" to "portal.themes" to control the whole feature.

      Add a second property to control all themes and adjust the current property ("portal.themeswitcher") to only control the theme switcher in the account menu. (Changed to "portal.themes.switcher")

      Add a third property ("portal.themes.autoDetectDark=true") to enable the detection of users' OS dark mode, which is disabled by default.

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  sfoster9 Shawn Foster
                  Reporter:
                  sfoster9 Shawn Foster
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration