Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-45164

Announcements: Undefined counter in Reorder velocity template

    XMLWordPrintable

    Details

    • 21 Status:
      Verified
    • 20 status:
      Verified
    • 19 status:
      Please Merge
    • Test Plan:
      Hide
      1. Create more than one announcement in the Announcements tool.
      2. Click the Reorder tab.
      3. Either by viewing the raw HTML source of the page or by using your browsers inspector tools, search the HTML for the string '$rowCount'. If that string is found within the "id" attribute of an html element, the bug is manifest. (In the Console tab of Chrome DevTools, you will also see this bug manifest as DOM warnings about elements found with "elements with non-unique id #check-$rowCount". See the attached screenshot.)  
      Show
      Create more than one announcement in the Announcements tool. Click the Reorder tab. Either by viewing the raw HTML source of the page or by using your browsers inspector tools, search the HTML for the string '$rowCount'. If that string is found within the "id" attribute of an html element, the bug is manifest. (In the Console tab of Chrome DevTools, you will also see this bug manifest as DOM warnings about elements found with "elements with non-unique id #check-$rowCount". See the attached screenshot.)  

      Description

      The velocity template for the Reorder view in the Announcements tool includes a reference to an undefined variable ($rowCount), used to compose the 'id' attribute for some (normally hidden) checkboxes. 

      While I'm not sure under what conditions the aforementioned checkboxes would actually display, the bug manifests as invalid HTML whereby the id for each checkbox will not be unique when more than one announcement is created in the site. (See the attached screenshot which displays warnings in Chrome DevTools.)

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                hornersa Sean Horner
                Reporter:
                hornersa Sean Horner
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration