Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-45397

IP filter list is broken (single IPs are taken as they ended with wildcards)

    XMLWordPrintable

    Details

    • 21 Status:
      Verified
    • 20 status:
      Verified
    • Test Plan:
      Hide

      In an exam, put an ip in filter list and access to this exam with an ip that is not the same as the one in the list but begins with the ip in the list.

      I.e, put 192.168.1.1 in the ip list and go to the exam with a device with ip 192.168.1.12

      Show
      In an exam, put an ip in filter list and access to this exam with an ip that is not the same as the one in the list but begins with the ip in the list. I.e, put 192.168.1.1 in the ip list and go to the exam with a device with ip 192.168.1.12

      Description

      Hi,

      A single IP (without a wildcard) is taken as prefix, not as a single IP.  So, if we put in the filter a single IP as 192.168.1.1 it allows access to all ips of the pattern 192.168.1.1*  (i.e. wil allow not only 192.168.1.1 but all in the range of 192.168.1.1x and 192.168.1.1xx ) 

      validateIP() in samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java checks ip with startsWith()

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                daniel.merino Daniel Merino Echeverría
                Reporter:
                javier.carrillo Javier Carrillo
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration