Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-45520

Fix triple scroll bars in Lessons BLTI Picker

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 22.0 [Tentative]
    • Component/s: Lessons
    • Labels:
      None
    • Test Plan:
      Hide

      Have an LTI App Store configured.   Go into Lessons and "Add Learning App" - check for triple scrollbars.  Once you verify that there are not three scroll bars - resize the overall window using varying dimensions and and make sure it remains responsive and no scrollbars appear when resized both horizontally and vertically.  Also check Chrome and FireFox

      Show
      Have an LTI App Store configured.   Go into Lessons and "Add Learning App" - check for triple scrollbars.  Once you verify that there are not three scroll bars - resize the overall window using varying dimensions and and make sure it remains responsive and no scrollbars appear when resized both horizontally and vertically.  Also check Chrome and FireFox

      Description

      In SAK-44151 a min-height of 80vh was introduced on the modal iframe.   This leads to triple scrollbars (iframe, modal, and overall page).   It also looks like a border got added to iframes which triggers an unneeded scrollbar when an iframe has heights and width of 100% within a bounding element.  The size of the iframe needs to be set to the size of the modal content area and then let the iframe and page scrollbars do the work.  The modal should never have a scrollbar.

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                csev Charles Severance
                Reporter:
                csev Charles Severance
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration