Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-45639

setAttribute error when dark theme switcher is disabled

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 21.0, 22.0 [Tentative]
    • Fix Version/s: 22.0 [Tentative]
    • Component/s: Portal
    • Labels:
      None
    • 21 Status:
      Please Merge
    • Test Plan:
      Hide

      1. portal.themes.switcher=false has to be set (Which is currently the default)

      2. Go to any page with the browser console open. There shouldn't be a error message about themeswitcher. 

      Show
      1. portal.themes.switcher=false has to be set (Which is currently the default) 2. Go to any page with the browser console open. There shouldn't be a error message about themeswitcher. 

      Description

      When darktheme is disabled there's a javascript error in the log because darkthemeswitcher is undefined.

      themeswitcher.js?version=a37c546a:63 Uncaught TypeError: Cannot read property 'setAttribute' of null
       at setDarkThemeSwitcherToggle (themeswitcher.js?version=a37c546a:63)
       at enableDarkTheme (themeswitcher.js?version=a37c546a:79)
       at init (themeswitcher.js?version=a37c546a:21)
       at sakaiThemeSwitcher (themeswitcher.js?version=a37c546a:9)
       at themeswitcher.js?version=a37c546a:95

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration