Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-35984

Duplicate file name breaks donwload zip

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8.4 [Tentative], 2.8.x
    • Fix Version/s: 2.9.0
    • Labels:
      None
    • 2.9 Status:
      Resolved
    • Previous Issue Keys:
      SAM-1468

      Description

      We had a case where a student uploaded 2 files with the same name as part of an file upload question.

      This causes the download zip to fail with an error:

      011-11-10 15:37:56,013 ERROR TP-Processor236 org.sakaiproject.tool.assessment.ui.servlet.delivery.DownloadAllMediaServlet - duplicate entry: Pretorius_Willem-petrus_prtwil005_IS2011B_PRTWIL005.accdb
      java.util.zip.ZipException: duplicate entry: Pretorius_Willem-petrus_prtwil005_IS2011B_PRTWIL005.accdb
      at java.util.zip.ZipOutputStream.putNextEntry(ZipOutputStream.java:175)
      at org.sakaiproject.tool.assessment.ui.servlet.delivery.DownloadAllMediaServlet.processOneMediaData(DownloadAllMediaServlet.java:334)
      at org.sakaiproject.tool.assessment.ui.servlet.delivery.DownloadAllMediaServlet.processNonAnonymous(DownloadAllMediaServlet.java:292)
      at org.sakaiproject.tool.assessment.ui.servlet.delivery.DownloadAllMediaServlet.doPost(DownloadAllMediaServlet.java:131)
      at org.sakaiproject.tool.assessment.ui.servlet.delivery.DownloadAllMediaServlet.doGet(DownloadAllMediaServlet.java:81)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:627)

      1) the download all shouldn't assume the name us unique.
      2) The catch needs to finer so that subsequent files get added to the zip

        Gliffy Diagrams

          Zeplin

            Attachments

            1. 081712_DownloadAll.png
              081712_DownloadAll.png
              51 kB
            2. 081712_DownloadZip.png
              081712_DownloadZip.png
              34 kB
            3. 081712_DupeFilesInZip.png
              081712_DupeFilesInZip.png
              49 kB
            4. ags1_MultiSubs.png
              ags1_MultiSubs.png
              13 kB
            5. file_numbering.png
              file_numbering.png
              130 kB

              Activity

                People

                Assignee:
                dhorwitz David Horwitz
                Reporter:
                dhorwitz David Horwitz
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Git Integration