Index: kernel-impl/src/main/java/org/sakaiproject/event/impl/ClusterEventTracking.java =================================================================== --- kernel-impl/src/main/java/org/sakaiproject/event/impl/ClusterEventTracking.java (revision 122805) +++ kernel-impl/src/main/java/org/sakaiproject/event/impl/ClusterEventTracking.java (working copy) @@ -545,16 +545,9 @@ if (M_log.isDebugEnabled()) M_log.debug("checking for events > " + m_lastEventSeq); // check the db for new events - // Note: the events may not all have sessions, so to get them we need an outer join. - // TODO: switch to a "view" read once that's established, for now, a join -ggolden + // We do a left join which gets us records from non-sessions also String statement = clusterEventTrackingServiceSql.getEventSql(); - // we might want a left join, which would get us records from non-sessions, which the above mysql code does NOT give -ggolden - // select e.EVENT_ID,e.EVENT_DATE,e.EVENT,e.REF,e.SESSION_ID,e.EVENT_CODE,s.SESSION_SERVER - // from SAKAI_EVENT e - // left join SAKAI_SESSION s on (e.SESSION_ID = s.SESSION_ID) - // where EVENT_ID > 0 - // send in the last seq number parameter Object[] fields = new Object[1]; fields[0] = Long.valueOf(m_lastEventSeq); Index: kernel-impl/src/main/java/org/sakaiproject/event/impl/ClusterEventTrackingServiceSqlDefault.java =================================================================== --- kernel-impl/src/main/java/org/sakaiproject/event/impl/ClusterEventTrackingServiceSqlDefault.java (revision 122805) +++ kernel-impl/src/main/java/org/sakaiproject/event/impl/ClusterEventTrackingServiceSqlDefault.java (working copy) @@ -45,8 +45,10 @@ */ public String getEventSql() { - return "select EVENT_ID,EVENT_DATE,EVENT,REF,SAKAI_EVENT.SESSION_ID,EVENT_CODE,CONTEXT,SESSION_SERVER " + "from SAKAI_EVENT,SAKAI_SESSION " - + "where (SAKAI_EVENT.SESSION_ID = SAKAI_SESSION.SESSION_ID) and (EVENT_ID > ?)"; + return "select EVENT_ID,EVENT_DATE,EVENT,REF,SAKAI_EVENT.SESSION_ID,EVENT_CODE,CONTEXT,SESSION_SERVER " + + "from SAKAI_EVENT " + + "left join SAKAI_SESSION ON SAKAI_EVENT.SESSION_ID = SAKAI_SESSION.SESSION_ID " + + "where (EVENT_ID > ?)"; } /**