[SAK-31881] Printable list view of calendar doesn't include message Created: 21-Oct-2016  Updated: 15-Feb-2017  Resolved: 24-Oct-2016

Status: Verified
Project: Sakai
Component/s: Calendar
Affects Version/s: 10.7, 11.1
Fix Version/s: 10.8 [Tentative], 11.3

Type: Bug Priority: Critical
Reporter: Matthew Jones Assignee: Hunter Sonn
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File SAK-31881-List-View.png    
Issue Links:
Relate
relates to SAK-21497 Allow subscriptions to non-public cal... Closed
11 status: Resolved
10 status: Resolved
Test Plan:
  • Create a site with calendar
  • Add an event, fill in the message box, the rest doesn't matter
  • Go to List of Events view
  • Click Printable Version
  • Expected, the message will be included in the printout (like it is on the page), before it wasn't. But back in 2.9 it was.

 Description   

This actually is a regression and it used to work on 2.9.0 (last version I tested it) but it doesn't work on more recent versions of Sakai 10.

If you add an event to calendar with a message, then click "List of Events" and Printable view. It previously had the description (in the message box), now it's no longer included.



 Comments   
Comment by Hunter Sonn [ 21-Oct-2016 ]

Matt, Chuck and I are taking a look at this.

Comment by Hunter Sonn [ 21-Oct-2016 ]

We're part way through. Let me know if you already have a fix for this

Comment by Matthew Jones [ 21-Oct-2016 ]

Nope, all yours assigned to you.

Comment by Matthew Jones [ 21-Oct-2016 ]

I fixed it so Hunter Sonn should be assignable issues and have greater access to jira too if you wanted to pick up others.

Comment by Sam Ottenhoff [ 28-Oct-2016 ]

Tested on nightly2

Comment by Hunter Sonn [ 29-Nov-2016 ]

I don't understand what changes were made. I still have event.getDescription() as the fourth parameter in my code on line 6488. Did someone find a solution to this bug. I've dug into it, and haven't found anything yet, so I'm open to hear people's findings.

Comment by Sam Ottenhoff [ 29-Nov-2016 ]

I don't understand your comment Hunter. I merged the master commits into the 11.x branch this afternoon.

Comment by Hunter Sonn [ 29-Nov-2016 ]

I was confusing myself with another bug I've been working on in base calendar. I worked with CSEV on this bug a while back and just forgot that I created the PR for it. The reason why I didn't understand what changes were made was because I was expecting the git diff in the comments section to be different from the code I have locally, but since I'm the one who made the changes, that makes sense now.

Comment by Mateu Llas Rubio [ 15-Feb-2017 ]

Tested in Sakai - 11.3-RC01 2017/02/10 in https://qa1-us.nightly.sakaiproject.org/portal
Test fails, message is not included in printed document.

Generated at Tue Oct 23 20:51:30 CDT 2018 using JIRA 7.5.0#75005-sha1:fd8c849d4e278dd8bbaccc61e707a716ad697024.