[SAK-32137] Instructors can change course site title during initial creation even if choosing a roster Created: 01-Feb-2017  Updated: 04-Nov-2017  Resolved: 02-Feb-2017

Status: Verified
Project: Sakai
Component/s: Worksite Setup
Affects Version/s: 11.2
Fix Version/s: 11.5 [Tentative], 12.0

Type: Bug Priority: Critical
Reporter: Paul Lukasewych Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relate
relates to SAK-29823 Site type title not editable sakai.pr... CLOSED
relates to SAK-31261 site-manage - create site with no ros... Verified
11 status: Resolved
Test Plan:
  • Log in to a system with the "Continue with no roster" feature enabled (see SAK-31261 for details), with demo account "instructor" , pw sakai
  • Create a new course site using a roster. Confirm that the site title matches the roster title and cannot be edited by the user.
  • Create a new course site using the "Continue with no roster" option. Confirm that the site title can be edited by the user.
  • Create a new course site, selecting a roster, and notice that the site title matches the roster title
    • Go back and use the "Continue with no roster" option instead
    • Confirm that the site title no longer matches the roster you originally selected and that you can edit the site title
    • Repeat the above, but also choose to use the the official description, confirming it is also cleared from the site description after you go back and select "Continue with no roster".
  • Try out various scenarios of moving through the wizard screens and choosing different options related to roster/no roster selection, site title, and site description, in different orders. Confirm there are no cases where user-entered data is lost without reason.

 Description   

By default, the title of a course site is not editable.

In SAK-29823 we enforced the titleNotEditable property in all scenarios, including initial site creation, so that instructors could not change the title of a course site. This assumed that a roster would always be chosen for the course site and the title would be taken from the roster. This lead to problems when the "Continue with no roster" feature was enabled (it is off by default), so in SAK-31261 changes were made to address that problem which essentially reverted SAK-29823, allowing instructors to change course site titles during site creation.

This patch attempts to address both uses cases above. If a course site is using a roster, the title will not be editable. If an instructor chooses to "Continue with no roster", a site title must be provided, so we allow it to be edited. This is accomplished by checking to see if a roster is attached or not.

Due to the setup process being a wizard that maintains state between pages, it is possible to first select a roster, then go back and decide to continue with no roster. Previously the old roster would remain in the state and would be considered attached for the checks above, so this patch clears any roster selections from the state when "Continue with no roster" is chosen. It also attempts to detect if the site title and/or description were assigned by the roster selection and removes them unless the user has edited them already.



 Comments   
Comment by Neal Caidin [ 14-Apr-2017 ]

Test Plan?

My first reading of this my reaction is it sounds logical but might it cause unexpected surprises for users?

Comment by Neal Caidin [ 28-Sep-2017 ]

Can you please elaborate on the part of the Test Plan that says:

"

  • Create a new course site, selecting a roster at first and then going back and using the "Continue with no roster" option. Confirm that the site title no longer matches the roster you previously selected, and that you can edit the site title. Also check that when using the official description, it is also cleared after going back to continue with no roster."

 

Maybe provide step-by-step on how to replicate? 

 

Comment by Neal Caidin [ 29-Sep-2017 ]

Thanks for updating the Test Plan. But more specifically the part I am not clear on is 

"

  • Go back and using the "Continue with no roster" option instead 

What does that mean, in step  by step format preferably? Thanks

 

Comment by Paul Lukasewych [ 29-Sep-2017 ]

Maybe the option is not enabled on the nightlys? SAK-31261 lists the required configuration.

Comment by Matthew Jones [ 03-Nov-2017 ]

Kenneth Aragon tested this locally, marking as verified.

Generated at Sun Sep 15 05:59:42 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.