[SAK-32360] LTI instances removed when editing tools through Worksite Setup Created: 22-Mar-2017  Updated: 08-Dec-2018  Resolved: 21-Apr-2017

Project: Sakai
Component/s: BasicLTI, Lessons, Site Info
Affects Version/s: 12.0
Fix Version/s: 11.5 [Tentative], 12.0

Type: Bug Priority: Blocker
Reporter: Matthew Buckett Assignee: Neal Caidin
Resolution: Fixed Votes: 0
Labels: qatestplanneeded
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
is depended on by SAK-32665 LTI Tools added to template sites don... RESOLVED
is depended on by SAK-40487 NullPointerException when creating si... RESOLVED
is related to SAK-24125 BasicLTI tool instance is added with ... Awaiting Review
is related to SAK-33892 NPE creating site with LTI tool and t... Verified
is related to SAK-31928 External Tool Import does not appear ... Verified
is related to SAK-40082 Common Cartridge Imports Not Importin... Verified
11 status: Resolved


If you have a globally registered LTI tool and it's been added to multiple sites, if you then attempt to edit a site's tool list through worksite setup it will have the tool pre-ticked in the site and when you untick it it will remove the LTI tool from all the sites it has been added to.

Comment by Matthew Buckett [ 22-Mar-2017 ]

The problem here is that the current placement is !admin, but the site being edited could be any site ID.

Comment by Matthew Buckett [ 22-Mar-2017 ]

So in lots of places inside LTIServices it gets the current site ID from the context which is the wrong thing todo when being called as a helper from Worksite Setup.

Comment by Matthew Buckett [ 20-Apr-2017 ]

There is a bug in this with tools that are just available to the site no longer working.

Comment by Neal Caidin [ 01-Sep-2017 ]

Test plan for this one?

Comment by Matthew Jones [ 21-May-2018 ]

This was incorporated in 11.x by SAK-32665

Generated at Fri Feb 21 20:31:31 CST 2020 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.