[SAK-32806] Settings panels no longer collapse Created: 02-Feb-2017  Updated: 17-Oct-2017  Resolved: 13-Feb-2017

Status: CLOSED
Project: Sakai
Component/s: Gradebook
Affects Version/s: 11.2
Fix Version/s: 11.3, 11.5 [Tentative]

Type: Bug Priority: Blocker
Reporter: Steve Swinsburg Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: GBNGImportIssue, GradebookNG
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relate
relates to SAK-32853 Popovers broken in GradebookNG CLOSED
Previous Issue Keys: GIT2-3841
Previous GIT issue: 3842

 Description   

Discovered whilst addressing GIT2-3755 - the settings panels no longer collapse. They open fine.
Maybe someone broke jQuery?
http://stackoverflow.com/questions/12646455/accordion-doesnt-collapse



 Comments   
Comment by Steve Swinsburg [ 07-Feb-2017 ]

From offline discussion with Payten Giles : Morpheus now loads bootstrap even if it has been loaded before.. so two events are bound to the link, so it closes and opens in quick succession
We can fix it by downgrading wicket's jquery down to v1.11.x (from v1.12.4) - but not sure if that's possible
Alternatively, we can allow v1.12.x to be supported more widely.. e.g.

Unable to find source-code formatter for language: `. Available languages are: actionscript, ada, applescript, bash, c, c#, c++, cpp, css, erlang, go, groovy, haskell, html, java, javascript, js, json, lua, none, nyan, objc, perl, php, python, r, rainbow, ruby, scala, sh, sql, swift, visualbasic, xml, yaml
--- a/portal/portal-render-engine-impl/pack/src/webapp/vm/morpheus/site.vm
+++ b/portal/portal-render-engine-impl/pack/src/webapp/vm/morpheus/site.vm
@@ -69,7 +69,7 @@
         }
         if ( window.jQuery ) {
             tver = jQuery.fn.jquery;
-            if ( tver.indexOf('1.11.') == 0 ) {
+            if ( tver.match(/^1\.1[1|2]\.[0-9]+/) ) { // match 1.11.x or 1.12.x

`

Comment by Payten Giles (Inactive) [ 09-Feb-2017 ]

A similar issue? https://github.com/steveswinsburg/sakai-widgets/commit/eaf94db462ef74549752f5c9a9fca14efca02b80

It looks like we can force Wicket to use Sakai's version of jQuery. That would preferable to introducing a new untested jQuery version to the entire application.

Comment by Steve Swinsburg [ 11-Feb-2017 ]

Yup I think that is the best way around this. This is the same approach we took when inlining the widgets.

Comment by Earle R Nietzel [ 13-Feb-2017 ]

Yeah typically you always want to use sakai's version of JS see PortalUtils and headscript for the JS version. A tool using a different version should really have some type of justification for doing so, as portal is loading jQuery ($PBJQ).

Comment by kyleblythe (Inactive) [ 13-Feb-2017 ]

Confirmed in 11.x maintenance branch: https://www.screencast.com/t/Ir6w6lqPHZ

Comment by Neal Caidin [ 03-Aug-2017 ]

This issue was imported from github issues. The use of Github issues as a bug tracker was an experiment with the GradebookNG (now just called Gradebook) tool development, released with Sakai 11. The information here may not be 100% accurate, please update or comment if any of the fields need updating.

Comment by Matthew Jones [ 14-Aug-2017 ]

Some new patches for this were merged to 11.5 to fix an issue related to the wicket upgrade.

Generated at Wed Sep 18 03:19:29 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.