[SAK-33356] For 11 branch - duplicate assignments does not preserve peer-review options Created: 13-Sep-2017  Updated: 10-Oct-2017  Resolved: 10-Oct-2017

Status: RESOLVED
Project: Sakai
Component/s: Assignments
Affects Version/s: 11.4
Fix Version/s: 11.5 [Tentative]

Type: Bug Priority: Blocker
Reporter: Raquel Alvarez Ramirez Assignee: Earle R Nietzel
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File duplicate_assignment_peer-review_options_not_populated.patch     PNG File duplicate_assignments_peer_reviewbug.png    
Issue Links:
Cloners
cloned from SAK-33443 For 12 and 13 branches - duplicate as... Verified
11 status: Resolved
Test Plan:

Please add a Test Plan here.


 Description   

In our 11.4 Sakai, when duplicating an assessment with peer-review settings, these do not get populated to the new copy.

We fixed this in: 

assignment/assignment-impl/impl/src/java/org/sakaiproject/assignment/impl/BaseAssignmentService.java

(see attached screenshot or comment with the patch text below)
We found another issue in the same category (although not dependant):
https://jira.sakaiproject.org/browse/SAK-33357



 Comments   
Comment by Sam Ottenhoff [ 25-Sep-2017 ]

Was a pull request submitted to Github?

Comment by Raquel Alvarez Ramirez [ 26-Sep-2017 ]

Sam Ottenhoff, unfortunately, we don't use Git yet.
We attached here the modification that fixed the issue for us.
I hope this helps.

Comment by Miguel Pellicer [ 03-Oct-2017 ]

Hi Raquel Alvarez Ramirez

I'll be glad to help here and contribute your patch, do you have a GitHub user so I can make a PR on your behalf?

Comment by Raquel Alvarez Ramirez [ 05-Oct-2017 ]

Miguel Pellicer, yes, thank you very much, I think this is my GitHub user: raquelalvarez-ramirez
I only used it to checkout Sakai for now.
Thanks again!

Comment by Miguel Pellicer [ 06-Oct-2017 ]

Please can you provide the text of the patch?

Thanks

Comment by Raquel Alvarez Ramirez [ 09-Oct-2017 ]

Miguel Pellicer is this enough or is there a way to get it in a better format?
(see attached)

Comment by Miguel Pellicer [ 10-Oct-2017 ]

Hi Raquel Alvarez Ramirez , seems we have an issue here.

Seems you resolved this for 11.x but Assignments was refactored in Master so the patch is not compatible with Master.

Can you reproduce this bug in Master?

https://trunk-mysql.nightly.sakaiproject.org/portal/

Maybe we can do a direct pull request against Sakai 11.x because Master has diverged, but the key here is check in master if it's affected by this issue.

Thanks and sorry for the inconvenience.

Comment by Raquel Alvarez Ramirez [ 10-Oct-2017 ]

Miguel Pellicer, at the moment we discovered the bug, Master was unstable regarding assignements and a lot of issues were being tackled in a sprint.
It wasn't possible to test this because it was not even possible to duplicate assignments: (for example see SAK-33318).
So we decided to fix it for our 11.4 and wait for the master branch to be stable again.

I will try to reproduce it now

Comment by Raquel Alvarez Ramirez [ 10-Oct-2017 ]

Unfortunately, I was able to reproduce it:

https://trunk-mysql.nightly.sakaiproject.org/portal/site/528bd7b8-8ff0-458c-9ba5-f41a65e990a0
 
 
It is a joinable site, but let me know if you cannot access it or spot the issue so I can elaborate a test plan.

Comment by Miguel Pellicer [ 10-Oct-2017 ]

It's fine, I'm sure we need two pull requests here, one for Master that can be merged back to 12.x and one for 11.x. I'll do the 11.x one.

Comment by Raquel Alvarez Ramirez [ 10-Oct-2017 ]

Miguel Pellicer, thanks for your help

Comment by Miguel Pellicer [ 10-Oct-2017 ]

Pull request for 11.x created:

https://github.com/sakaiproject/sakai/pull/4877

Comment by Matthew Jones [ 10-Oct-2017 ]

We created a new jira for fixing this in 12/13 SAK-33443

Comment by Neal Caidin [ 10-Oct-2017 ]

This is good for the 11 branch and we need a ticket for a separate fix on the 12 and 13 branches (13 is currently master).  New ticket for 12/13 - SAK-33443 

 

Generated at Sun Sep 22 10:42:53 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.