[SAK-33357] For 11 - duplicate site with peer review assignments copies the settings but misses one Created: 13-Sep-2017  Updated: 10-Oct-2017  Resolved: 10-Oct-2017

Status: RESOLVED
Project: Sakai
Component/s: Assignments
Affects Version/s: 11.4
Fix Version/s: 11.5 [Tentative]

Type: Bug Priority: Blocker
Reporter: Raquel Alvarez Ramirez Assignee: Earle R Nietzel
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File duplicate_site_containing_assignments_peer_review_bug.png     Text File duplicate_site_misses_peer-review_options.patch    
Issue Links:
Cloners
cloned from SAK-33444 For 12/13 - duplicate site with peer ... RESOLVED
Test Plan:

Please add a Test Plan here.


 Description   

When duplicating a site that contains peer review assignments these get copied too.

However all the settings get copied:

  • peer review instructions
  • anonymous evaluation
  • number of reviews
  • student allowed to be reviews

Except one:

  • allow peer review

 

We fixed this in: 

assignment/assignment-impl/impl/src/java/org/sakaiproject/assignment/impl/BaseAssignmentService.java

(see attached screenshot)

A database script was also needed to modify that property in the items already affected by this bug.
The following worked for us; since our teachers always input peer review assignment instructions when they make use of a peer review assignment

UPDATE assignment_assignment
SET xml = REPLACE(xml, 'allowpeerassessment="false"', 'allowpeerassessment="true"') WHERE xml like '%allowpeerassessment="false"%'
and xml not like '%peerassessmentinstructions=""%';

Otherwise, the last part

and xml not like '%peerassessmentinstructions=""%'

should be modified to make sure that we are making peer review assignments only the ones that actually are.

We found another issue in the same category (although not dependant):
https://jira.sakaiproject.org/browse/SAK-33356



 Comments   
Comment by Sam Ottenhoff [ 25-Sep-2017 ]

Why was this issue resolved? Was any code modified?

Comment by Raquel Alvarez Ramirez [ 26-Sep-2017 ]

Sam Ottenhoff unfortunately, we don't use Git yet.
We attached here the modification that fixed the issue for us.
I hope this helps.

Comment by Miguel Pellicer [ 10-Oct-2017 ]

Hi Raquel Alvarez Ramirez , seems we have an issue here.

Seems you resolved this for 11.x but Assignments was refactored in Master so the patch is not compatible with Master.

Can you reproduce this bug in Master?

https://trunk-mysql.nightly.sakaiproject.org/portal/

Maybe we can do a direct pull request against Sakai 11.x because Master has diverged, but the key here is check in master if it's affected by this issue.

Thanks and sorry for the inconvenience.

Comment by Raquel Alvarez Ramirez [ 10-Oct-2017 ]

Miguel Pellicer, at the moment we discovered the bug, Master was unstable regarding assignements and a lot of issues were being tackled in a sprint.
It wasn't possible to test this because it was not even possible to duplicate assignments: (for example see SAK-33318).
So we decided to fix it for our 11.4 and wait for the master branch to be stable again.

I will try to reproduce it now 

Comment by Raquel Alvarez Ramirez [ 10-Oct-2017 ]

The duplicate site option is disabled (for normal users) in Site Info, hence I am not able to reproduce the issue.

However, I was able to reproduce the related one: https://jira.sakaiproject.org/browse/SAK-33356

So I presume this issue is also still in master

 

Comment by Matthew Jones [ 10-Oct-2017 ]

Created 12/13 issue as SAK-33444

Generated at Sun Sep 15 05:54:12 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.