[SAK-33863] Gradebook Classic does not display item's class average when grades are set to display as percentage Created: 23-Jan-2018  Updated: 10-Apr-2018  Resolved: 06-Feb-2018

Status: Verified
Project: Sakai
Component/s: Gradebook Classic
Affects Version/s: 11.4, 12.0, 19.0 [Tentative]
Fix Version/s: 11.5 [Tentative], 12.1, 19.0 [Tentative]

Type: Bug Priority: Critical
Reporter: Austin Assignee: Matthew Jones
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File item details.png     JPEG File overview.jpg    
Issue Links:
Depend
depends on SAK-33464 Allow on-the-fly calculation of cours... Verified
Relate
relates to SAK-31840 Remove primitive types on GradableObject Closed
12 status: Resolved
11 status: Resolved
Test Plan:

Please add a Test Plan here.


 Description   

Steps:

  • Open Gradebook Classic tool
  • click gradebook setup
  • under "How will graders enter grades into this gradebook?" select Percentages
  • save
  • go back to gradebook items
  • create a gradebook item (if one doesn't exist)
    • add some grades to it
  • The gradebook item's "Class Average" is not displayed
  • click the gradebook item to view it's details
  • The gradebook detail page's "Class Average" is not displayed


 Comments   
Comment by Austin [ 23-Jan-2018 ]

looks like there were changes in 10.7 to 11.4 in Assignment.java

line 497 and line 520

- if(!ungraded && pointsPossible > 0)
+ if(getUngraded() && pointsPossible > 0)

- if(!ungraded && pointsPossible > 0)
+ if(getUngraded() && pointsPossible > 0)

where the getUngraded() function was added in, but ! wasn't included. so changing that line from

- if(getUngraded() && pointsPossible > 0)
+ if(!getUngraded() && pointsPossible > 0)

seems to make it work in sakai 11.4.

I haven't tested in sakai 12, where the Assignment.java file appears to have been replaced by GradebookAssignment.java, but the code looks the same, so I would expect the fix above to work there too. (note, to enable gradebook classic, you need to unstealth it from kernel.properties)

Comment by Matthew Jones [ 29-Jan-2018 ]

Thanks Austin
Commits put in for 13/12 as https://github.com/sakaiproject/sakai/pull/5253

and 11.x as https://github.com/sakaiproject/sakai/pull/5254

Comment by Derek Ramsey [ 09-Feb-2018 ]

Verified on 13x that gradebook configured to use percentages will display the class average on an item.

Comment by Matthew Jones [ 13-Feb-2018 ]

12.x depends on getting SAK-33464 fixed. I could add the same fix for 11 but then it'll cause a conflict against that one.

Generated at Mon Dec 10 12:32:27 CST 2018 using JIRA 7.5.0#75005-sha1:fd8c849d4e278dd8bbaccc61e707a716ad697024.