[SAK-33960] Assignments List: Instructor is not able to see assignments of his group Created: 27-Feb-2018  Updated: 16-Apr-2018  Resolved: 07-Mar-2018

Status: Verified
Project: Sakai
Component/s: Assignments
Affects Version/s: 11.4
Fix Version/s: 11.5 [Tentative]

Type: Bug Priority: Blocker
Reporter: Miguel Pellicer Assignee: Miguel Pellicer
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: JPEG File Sakai SMPL202 Spring 2018 Assignments - Google Chrome.jpg     JPEG File Sakai SMPL202 Spring 2018 Assignments - Google Chrome_2.jpg     JPEG File Sakai SMPL202 Spring 2018 Assignments - Google Chrome_3.jpg     PNG File Sin título.png     Text File image-2018-03-02-08-39-58-297.png     Text File image-2018-03-07-08-23-52-010.png    
Issue Links:
Relate
relates to SAK-34101 Assignments List: Instructor doesn't ... OPEN
11 status: Resolved
Test Plan:

Steps to reproduce (Confirmed in 11.x nightly):

  1. Login as admin
  2. Create a new course site with demo data (I used SPRING 2018).
  3. Assign at least one group (I used "SMPL101 Spring 2018 Lecture").
  4. Remove all permissions for the instructor role at site level except asn.read, leave the group by default.
  5. Create one assignment at site level.
  6. Create one assignment at group level (Assign SMPL101 Spring 2018 Lecture).
  7. Login as instructor (the credentials instructor/sakai may work).
  8. You'll not see anything.
  9. Create one assignment at group level (Assign SMPL101 Spring 2018 Lecture).
  10. You'll not see anything (if the assignments are not open) and you've created the assignment!

 Description   

The instructor is not able to see assignments of his group until they are open, even if the instructor created the assignment.



 Comments   
Comment by Miguel Pellicer [ 27-Feb-2018 ]

I've tested in 12.x and it's not reproducible.

Comment by Miguel Pellicer [ 27-Feb-2018 ]

With this FIX, there is only one difference with 12.x, the instructor is able to see the assignments assigned to the site before the open date, in 11.x is not able to see them.

I'm confused, is it a correct behavior or a 12.x bug? IMHO an instructor shouldn't see the site level assignments if doesn't have permissions to edit so sounds like a 12.x bug for me.

Comment by Miguel Pellicer [ 27-Feb-2018 ]

More info about the FIX.

Current behavior (Buggy):

  1. To get the list of assignments checks the asn.read permission at site level.
  2. To determine the visibility checks the dates and the deletion status.
  3. To check the permissions on editing, editAssignment looks for site and group permissions, editAssignmentContent looks only for site permissions (both are asn.revise).

After the fix behavior:

  1. To get the list of assignments checks the asn.read permission at site and group level.
  2. To determine the visibility checks the dates, the deletion status and the permissions of the groups which the assignment is configured.
  3. To check the permissions on editing, editAssignment looks for site and group permissions, editAssignmentContent looks for the same permissions (both are asn.revise).

 

Comment by Derek Ramsey [ 01-Mar-2018 ]

Unable to replicate on 11x nightly, can you review my steps and see what may be missing?

1.  Login as admin

2.  Create a new course site

3.  Assign at least one group

4.  Remove all permissions for the instructor role at site level except asn.read, leave the group by default.  I did this by selecting Assignments->Permissions.  The only options I left checked for instructor were:

Same site level permissions for all groups inside the site
Read assignment(s)

5.  Created two assignments at site level - one open and one not yet open

6.  Create two assignment at group level - one open and one not yet open

7.  Login as instructor (the credentials instructor/sakai may work).

8.  I see all 4 assignments

9.  While still logged in as instructor, created one assignment with group.

10.  After saving, I now see all 5 assignments listed.

 

Comment by Miguel Pellicer [ 02-Mar-2018 ]

I was able to replicate the problem, I've created the course site using this group:

Then, I've assigned the permissions:

 

After I've created two assignments (1 site level, 1 group level), this is what the administrator sees:

This is what the instructor sees:

After I've created an assignment as instructor at group level, this is what the instructor sees:

 

 

 

Comment by Derek Ramsey [ 05-Mar-2018 ]

Miguel,

 

Thanks for the followup.  I was able to replicate the reported issue on 11x. 

Comment by Derek Ramsey [ 06-Mar-2018 ]

Tested this afternoon after 11x was rebuilt.  Still able to replicate following the provided steps.

Comment by Miguel Pellicer [ 07-Mar-2018 ]

Tested right now in 11x, seems fixed. I'm not able to replicate the problem, as Instructor I see both assessments, the one created for the group by the admin and the one created by the instructor, both are not open and I can see them.

 

Comment by Derek Ramsey [ 07-Mar-2018 ]

Miguel - I was also successful in my test this morning for verifying this JIRA.

Comment by Shawn Foster [ 07-Mar-2018 ]

Miguel Pellicer, are you able to now edit and save changes to that assignment with your fix?

Comment by Miguel Pellicer [ 08-Mar-2018 ]

Shawn Foster yes, the first issue was the instructor not being able to see their assignments, the second issue found he was unable to edit the assignment nor his contents. This JIRA fixes both cases, could you confirm it?

Comment by Shawn Foster [ 08-Mar-2018 ]

Thanks for confirming.

Yes, I just tried it out on 11.x nightly and it seems to be working as expected for the suggested use case.

I tried to determine what another instructor who isn't in the section or group would see, but that user could still see all of the assignments as well. I can't determine if this is a result of this fix or if it is caused by the structure of the demo data in the course site.

You can see what I mean on https://qa11-mysql.nightly.sakaiproject.org/portal/site/2c600d38-6731-4c53-a3e4-2c9bcc825e1b today by comparing the "instructor" user to the "instructor2" user.

Comment by Miguel Pellicer [ 08-Mar-2018 ]

Both instructors belong to the same sections so they will see the same assignments.

Comment by Nadine, Blanchette [ 05-Apr-2018 ]

The instructor should also see the assignments that are for the whole site, since is group is part of it.
The instructor has the section.role.instructor, so we know he is not a student.

Generated at Mon Sep 16 16:37:00 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.