[SAK-34018] Student View of Gradebook throws a Stack Trace Created: 14-Mar-2018  Updated: 08-Oct-2018  Resolved: 14-Mar-2018

Status: Verified
Project: Sakai
Component/s: Assignments, Gradebook
Affects Version/s: 11.5 [Tentative], 12.0, 19.0
Fix Version/s: 11.5 [Tentative], 12.0, 19.0

Type: Bug Priority: Blocker
Reporter: Neal Caidin Assignee: Earle R Nietzel
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File gb_stack_trace_rc03.txt    
Issue Links:
Relate
relates to SAK-33396 Cleanup use of pushAdvisor and popAdv... Verified
is related to SAK-34019 Viewing announcement stack trace Verified
12 status: Resolved
11 status: Resolved
Test Plan:

Please add a Test Plan here.


 Description   

To reproduce:

  1. Create a site with Assignments and Gradebook tools.
  2. Create an Assignment with points and add to Gradebook (not with existing item).
  3. As a student in the site, log in and click on Gradebook.

Result: You are displayed a stack trace.

See stack trace included.

 



 Comments   
Comment by Neal Caidin [ 14-Mar-2018 ]

I can reproduce on master trunk nightly mysql.

 

Comment by Matthew Jones [ 14-Mar-2018 ]

Stack trace looks related to the recent fix on KNL-1587. We'd either need to back that one out or figure out the issue with it asap.

Comment by Neal Caidin [ 14-Mar-2018 ]

I can't reproduce the problem on 11. x nightly mysql.

 

Comment by Matthew Jones [ 14-Mar-2018 ]

Looks like some new code in 12 assignment getAssignment, it pushes in and pops out in the wrong order. This is LIFO now and enforced.

    private Assignment getAssignment(String assignmentReference) {
. . .
                securityService.pushAdvisor(accessAssignmentAdvisor);
                securityService.pushAdvisor(accessGroupsAdvisor);
. . . 
                securityService.popAdvisor(accessAssignmentAdvisor);
                securityService.popAdvisor(accessGroupsAdvisor);
Comment by Earle R Nietzel [ 14-Mar-2018 ]

Regression from SAK-33396

Generated at Sun Sep 15 06:00:32 CDT 2019 using Jira 8.0.3#800011-sha1:073e8b433c2c0e389c609c14a045ffa7abaca10d.